diff options
author | Pascal Quantin <pascal.quantin@gmail.com> | 2015-12-06 22:29:53 +0100 |
---|---|---|
committer | Anders Broman <a.broman58@gmail.com> | 2015-12-09 16:54:33 +0000 |
commit | afaf929d0da03a27ef8824eac3c6b45b4419b062 (patch) | |
tree | 72f4cf70904fa1162acea8d53e22f0ba413b43d1 /ui/qt/main_window.h | |
parent | eb9d7ebb20976a57ba9693f5f7b5277675849471 (diff) | |
download | wireshark-afaf929d0da03a27ef8824eac3c6b45b4419b062.tar.gz |
Qt: various fixes to VoIP calls / RTP player windows
- Flush any remaining tapped packets before emitting captureFileRetapFinished().
This ensures that all packets have been treated before returning from retapPackets().
- Remove VoIP tap listeners when captureFileRetapFinished() is emitted.
This avoid summing stats each time the RTP player is opened, leading to wrong
information in VoIP calls window
- Change voip_calls_tapinfo_t redraw member from a boolean to bitmap so as to identify
which tap should call the tapinfo->tap_draw() callback. This allows fixing a race condition
where the RTP player can be empty in Qt UI
- Reset some more statistics in voip_calls_reset_all_taps()
Change-Id: Ie7681702c81d338185c1813f2d340a437edf3a04
Reviewed-on: https://code.wireshark.org/review/12474
Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Anders Broman <a.broman58@gmail.com>
Diffstat (limited to 'ui/qt/main_window.h')
-rw-r--r-- | ui/qt/main_window.h | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/ui/qt/main_window.h b/ui/qt/main_window.h index bb9d6b50d9..204eb99f6a 100644 --- a/ui/qt/main_window.h +++ b/ui/qt/main_window.h @@ -251,6 +251,7 @@ public slots: void captureFileRescanStarted() { setMenusForCaptureFile(true); captureFileReadStarted(tr("Rescanning")); } void captureFileRetapStarted(); void captureFileRetapFinished(); + void captureFileFlushTapsData(); void captureFileClosing(); void captureFileClosed(); void captureFileSaveStarted(const QString &file_path); |