diff options
| author | Guy Harris <guy@alum.mit.edu> | 2015-03-01 20:01:17 -0800 |
|---|---|---|
| committer | Guy Harris <guy@alum.mit.edu> | 2015-03-02 04:01:43 +0000 |
| commit | 99ceab898c8c809eb1584432c54872d7e368711b (patch) | |
| tree | da093a3560015e3e18d311d607343a7956c9701e /ui/qt/packet_dialog.h | |
| parent | 3108bf8d2ec57fe091a69d3f96b1f356964df41f (diff) | |
| download | wireshark-99ceab898c8c809eb1584432c54872d7e368711b.tar.gz | |
Don't create a packet dialog if we don't have a packet.
Move the "find the frame" stuff to openPacketDialog(), and don't even
bother creating a new PacketDialog if we don't find the frame. This
should squelch Coverity CID 1270934, by giving up quickly if fdata is
null.
Change-Id: I4605ba7e271a55724f02cafed4122f9dd9b1b6f7
Reviewed-on: https://code.wireshark.org/review/7467
Reviewed-by: Guy Harris <guy@alum.mit.edu>
Diffstat (limited to 'ui/qt/packet_dialog.h')
| -rw-r--r-- | ui/qt/packet_dialog.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/ui/qt/packet_dialog.h b/ui/qt/packet_dialog.h index adcadbfcc4..b806af0fe3 100644 --- a/ui/qt/packet_dialog.h +++ b/ui/qt/packet_dialog.h @@ -39,7 +39,7 @@ class PacketDialog : public WiresharkDialog Q_OBJECT public: - explicit PacketDialog(QWidget &parent, CaptureFile &cf, bool from_reference = false); + explicit PacketDialog(QWidget &parent, CaptureFile &cf, frame_data *fdata); ~PacketDialog(); signals: |