diff options
| author | Michael Mann <mmann78@netscape.net> | 2015-12-30 15:28:07 -0500 |
|---|---|---|
| committer | Michael Mann <mmann78@netscape.net> | 2016-01-01 17:36:11 +0000 |
| commit | b344107d757466e0768a3ef8927852479e926cf6 (patch) | |
| tree | 7e5599b63bd060f710ad37d053d504f448589476 /ui/qt/packet_list_record.cpp | |
| parent | b1281c8308a6ea11da91e022a2e7c407ab94c864 (diff) | |
| download | wireshark-b344107d757466e0768a3ef8927852479e926cf6.tar.gz | |
Make color filters part of dissection
Color filters can be seen as a function that takes a tree and display
filters as input and a (possibly empty) coloring rule as output.
This coloring rule is then added to the frame tree and used by the GUI
for coloring the packets list.
From an architectural POV, "coloring" is part of the UI component, but
since it influences the tree, it is something for the dissection
component.
Bug: 5703
Bug: 6099
Change-Id: I73d132ec1dca7262bcb1b55c8481ca564c6161d1
Reviewed-on: https://code.wireshark.org/review/12507
Petri-Dish: Michael Mann <mmann78@netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Michael Mann <mmann78@netscape.net>
Diffstat (limited to 'ui/qt/packet_list_record.cpp')
| -rw-r--r-- | ui/qt/packet_list_record.cpp | 3 |
1 files changed, 0 insertions, 3 deletions
diff --git a/ui/qt/packet_list_record.cpp b/ui/qt/packet_list_record.cpp index 26f147feed..b6659db550 100644 --- a/ui/qt/packet_list_record.cpp +++ b/ui/qt/packet_list_record.cpp @@ -151,9 +151,6 @@ void PacketListRecord::dissect(capture_file *cap_file, bool dissect_color) */ epan_dissect_run(&edt, cap_file->cd_t, &phdr, frame_tvbuff_new_buffer(fdata_, &buf), fdata_, cinfo); - if (dissect_color) - fdata_->color_filter = color_filters_colorize_packet(&edt); - if (dissect_columns) { /* "Stringify" non frame_data vals */ epan_dissect_fill_in_columns(&edt, FALSE, FALSE /* fill_fd_columns */); |