diff options
author | Gerald Combs <gerald@wireshark.org> | 2015-08-26 17:14:39 -0700 |
---|---|---|
committer | Gerald Combs <gerald@wireshark.org> | 2015-08-28 02:54:20 +0000 |
commit | f19a173a8409ff62a77939e66b4a97d26cc5c149 (patch) | |
tree | 9530c97f8ebafd0d0a791cf1f08aa5f4e90fcdb7 /ui/qt/packet_list_record.h | |
parent | 01fb470acd71528bede068727b7614ae6f534c4f (diff) | |
download | wireshark-f19a173a8409ff62a77939e66b4a97d26cc5c149.tar.gz |
Speed up column sorting.
The GTK+ UI sequentially dissects and caches column strings for all rows
before sorting a column. Do the same in the Qt UI, which can improve
performance considerably.
Don't colorize packets when sorting in the Qt UI unless it's necessary.
When sorting in the Qt UI, let the user cancel the initial packet
dissection. Note that we'll need to replace std::sort in order to
cancel out of sorting.
Use a pre-allocated and pre-compiled GRexex when we prime columns. Note
that we probably shouldn't parse a regular expression there.
Cache the last result of proto_registrar_get_byname.
Note performance hot spots elsewhere in the code.
To do:
GeoIP in packet-ip.c is pretty slow.
Bug: 11467
Change-Id: Ib34038fee08ef0319261faeffc4eca01e52f4bd3
Reviewed-on: https://code.wireshark.org/review/10275
Petri-Dish: Gerald Combs <gerald@wireshark.org>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Gerald Combs <gerald@wireshark.org>
Diffstat (limited to 'ui/qt/packet_list_record.h')
-rw-r--r-- | ui/qt/packet_list_record.h | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/ui/qt/packet_list_record.h b/ui/qt/packet_list_record.h index 17d7c6ae82..c8d2e90a28 100644 --- a/ui/qt/packet_list_record.h +++ b/ui/qt/packet_list_record.h @@ -42,7 +42,7 @@ class PacketListRecord public: PacketListRecord(frame_data *frameData); // Return the string value for a column. Data is cached if possible. - const QVariant columnString(capture_file *cap_file, int column); + const QByteArray columnString(capture_file *cap_file, int column, bool colorized = false); frame_data *frameData() const { return fdata_; } // packet_list->col_to_text in gtk/packet_list_store.c static int textColumn(int column) { return cinfo_column_.value(column, -1); } @@ -75,7 +75,6 @@ private: void dissect(capture_file *cap_file, bool dissect_color = false); void cacheColumnStrings(column_info *cinfo); - }; #endif // PACKET_LIST_RECORD_H |