diff options
| author | Pascal Quantin <pascal.quantin@gmail.com> | 2016-12-22 09:36:18 +0100 |
|---|---|---|
| committer | Anders Broman <a.broman58@gmail.com> | 2016-12-22 12:54:48 +0000 |
| commit | 541beaad6e99c8efc8a57a8e87fd5e8c3d56056a (patch) | |
| tree | dc79b5e943ab4d1357eac1cbc002b6af33324e3a /ui/qt/rtp_analysis_dialog.h | |
| parent | 61d2c8f4a4fdca8f6d9055400a29f8c74580c313 (diff) | |
| download | wireshark-541beaad6e99c8efc8a57a8e87fd5e8c3d56056a.tar.gz | |
Qt: use references on tap_rtp_stat_t private members (CID 1397703 and 1397704)
This should solve the "passing parameter statinfo of type "tap_rtp_stat_t"
(size 5040 bytes) by value" warnings reported by Coverity.
Change-Id: I327906f7925ab21a914b8a98ff8481a0af9f7a2f
Reviewed-on: https://code.wireshark.org/review/19380
Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
Reviewed-by: Anders Broman <a.broman58@gmail.com>
Diffstat (limited to 'ui/qt/rtp_analysis_dialog.h')
| -rw-r--r-- | ui/qt/rtp_analysis_dialog.h | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/ui/qt/rtp_analysis_dialog.h b/ui/qt/rtp_analysis_dialog.h index c24de02d09..0251281294 100644 --- a/ui/qt/rtp_analysis_dialog.h +++ b/ui/qt/rtp_analysis_dialog.h @@ -163,8 +163,8 @@ private: size_t convert_payload_to_samples(unsigned int payload_type, QTemporaryFile *tempfile, gchar *pd_out, size_t expected_nchars); gboolean saveAudioAUSilence(size_t total_len, QFile *save_file, gboolean *stop_flag); - gboolean saveAudioAUUnidir(tap_rtp_stat_t statinfo, QTemporaryFile *tempfile, QFile *save_file, size_t header_end, gboolean *stop_flag, gboolean interleave, size_t prefix_silence); - gboolean saveAudioAUBidir(tap_rtp_stat_t fwd_statinfo, tap_rtp_stat_t rev_statinfo, QTemporaryFile *fwd_tempfile, QTemporaryFile *rev_tempfile, QFile *save_file, size_t header_end, gboolean *stop_flag, size_t prefix_silence_fwd, size_t prefix_silence_rev); + gboolean saveAudioAUUnidir(tap_rtp_stat_t &statinfo, QTemporaryFile *tempfile, QFile *save_file, size_t header_end, gboolean *stop_flag, gboolean interleave, size_t prefix_silence); + gboolean saveAudioAUBidir(tap_rtp_stat_t &fwd_statinfo, tap_rtp_stat_t &rev_statinfo, QTemporaryFile *fwd_tempfile, QTemporaryFile *rev_tempfile, QFile *save_file, size_t header_end, gboolean *stop_flag, size_t prefix_silence_fwd, size_t prefix_silence_rev); gboolean saveAudioAU(StreamDirection direction, QFile *save_file, gboolean *stop_flag, RtpAnalysisDialog::SyncType sync); gboolean saveAudioRAW(StreamDirection direction, QFile *save_file, gboolean *stop_flag); void saveAudio(StreamDirection direction, RtpAnalysisDialog::SyncType sync); |