diff options
| author | Gerald Combs <gerald@wireshark.org> | 2016-06-06 14:55:10 -0700 |
|---|---|---|
| committer | Gerald Combs <gerald@wireshark.org> | 2016-06-06 23:37:01 +0000 |
| commit | 0ec5a271ea96e92d80060bded7245749a71e199d (patch) | |
| tree | a90d9484db96db54954bcd56add8c6b1168de004 /ui/qt/rtp_player_dialog.cpp | |
| parent | f1ff3208a055f462e69c9ac7479271aecf784d79 (diff) | |
| download | wireshark-0ec5a271ea96e92d80060bded7245749a71e199d.tar.gz | |
Qt: RTP audio stream fixups.
Make sure audio_stream_ is non-NULL before we try to use it. Delete
audio_stream_ more gracefully and add a note about mutexes on OS X and
Windows.
Bug: 12166
Change-Id: I12e76c49e631bc1de813c5c7d82c7d928c71237e
Reviewed-on: https://code.wireshark.org/review/15759
Petri-Dish: Gerald Combs <gerald@wireshark.org>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Gerald Combs <gerald@wireshark.org>
Diffstat (limited to 'ui/qt/rtp_player_dialog.cpp')
| -rw-r--r-- | ui/qt/rtp_player_dialog.cpp | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/ui/qt/rtp_player_dialog.cpp b/ui/qt/rtp_player_dialog.cpp index 3dc9184312..161132973b 100644 --- a/ui/qt/rtp_player_dialog.cpp +++ b/ui/qt/rtp_player_dialog.cpp @@ -61,7 +61,7 @@ Q_DECLARE_METATYPE(QCPGraph *) // + dst port + ssrc. This means that we can have multiple rtp_stream_info // structs per RtpAudioStream. Should we make them 1:1 instead? -// Current RTP player bugs: +// Current and former RTP player bugs. Many have attachments that can be usef for testing. // Bug 3368 - The timestamp line in a RTP or RTCP packet display's "Not Representable" // Bug 3952 - VoIP Call RTP Player: audio played is corrupted when RFC2833 packets are present // Bug 4960 - RTP Player: Audio and visual feedback get rapidly out of sync @@ -72,6 +72,7 @@ Q_DECLARE_METATYPE(QCPGraph *) // Bug 10613 - RTP audio player crashes // Bug 11125 - RTP Player does not show progress in selected stream in Window 7 // Bug 11409 - Wireshark crashes when using RTP player +// Bug 12166 - RTP audio player crashes // XXX It looks like we duplicate some functionality here and in the RTP // analysis code, which has its own routines for writing audio data to a |