diff options
| author | Pascal Quantin <pascal.quantin@gmail.com> | 2015-10-25 22:52:30 +0100 |
|---|---|---|
| committer | Gerald Combs <gerald@wireshark.org> | 2015-10-26 23:57:51 +0000 |
| commit | 1ea43c26e68d92838a7d91dce4fe9686b09f12c7 (patch) | |
| tree | 65c8b3f84f589530b16fc6159974f1813aa8968d /ui/qt/sequence_dialog.cpp | |
| parent | d141562efb18f777c122405941bd5ef8c21513b1 (diff) | |
| download | wireshark-1ea43c26e68d92838a7d91dce4fe9686b09f12c7.tar.gz | |
Only store frame number and not a pointer to frame_data structure in seq_analysis_item_t
Qt GUI allows to keep windows open after closing the capture file. Let's not access to freed memory.
Bug: 11573
Change-Id: I9e70d818a4b228af319961ec512b6b9725792477
Reviewed-on: https://code.wireshark.org/review/11270
Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Gerald Combs <gerald@wireshark.org>
Diffstat (limited to 'ui/qt/sequence_dialog.cpp')
| -rw-r--r-- | ui/qt/sequence_dialog.cpp | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/ui/qt/sequence_dialog.cpp b/ui/qt/sequence_dialog.cpp index e30fcc6564..d96036b8a9 100644 --- a/ui/qt/sequence_dialog.cpp +++ b/ui/qt/sequence_dialog.cpp @@ -267,7 +267,7 @@ void SequenceDialog::mouseMoved(QMouseEvent *event) if (event) { seq_analysis_item_t *sai = seq_diagram_->itemForPosY(event->pos().y()); if (sai) { - packet_num_ = sai->fd->num; + packet_num_ = sai->frame_number; hint = QString("Packet %1: %2").arg(packet_num_).arg(sai->comment); } } |