diff options
| author | Kevin Hogan <kwabena@google.com> | 2016-12-22 13:03:03 -0800 |
|---|---|---|
| committer | Anders Broman <a.broman58@gmail.com> | 2017-01-04 05:24:30 +0000 |
| commit | 3fae1366d1041c3591a919ce91aed27f983715a9 (patch) | |
| tree | b660c793fbd69bb3687c732f1da609dbb9b53173 /ui/qt/tcp_stream_dialog.ui | |
| parent | 15ad25ecb52ed02d293062be0fa6f08743f461ad (diff) | |
| download | wireshark-3fae1366d1041c3591a919ce91aed27f983715a9.tar.gz | |
Qt: add SACK graphs to tcptrace graph
Primarily, this adds visual indication of SACK blocks to tcptrace.
In addition:
- cleaned up focus behavior for graph selector and spinboxes
- added time-delay update to streamNumber spinBox
(similar to behavior of maWindow spinBox)
- changed ACK selection to select only SACKed responses
(rather than all ACKs - SACKs seemed more useful to look at)
Change-Id: I47d9e98d54f14e4955008ecea791b77f805c8ba9
Reviewed-on: https://code.wireshark.org/review/19388
Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
Reviewed-by: Anders Broman <a.broman58@gmail.com>
Diffstat (limited to 'ui/qt/tcp_stream_dialog.ui')
| -rw-r--r-- | ui/qt/tcp_stream_dialog.ui | 24 |
1 files changed, 20 insertions, 4 deletions
diff --git a/ui/qt/tcp_stream_dialog.ui b/ui/qt/tcp_stream_dialog.ui index 4e7cea956a..cd49bb6f36 100644 --- a/ui/qt/tcp_stream_dialog.ui +++ b/ui/qt/tcp_stream_dialog.ui @@ -89,7 +89,14 @@ </widget> </item> <item> - <widget class="QComboBox" name="graphTypeComboBox"/> + <widget class="QComboBox" name="graphTypeComboBox"> + <property name="frame"> + <bool>false</bool> + </property> + <property name="focusPolicy"> + <enum>Qt::TabFocus</enum> + </property> + </widget> </item> <item> <widget class="QLabel" name="maWindowSizeLabel"> @@ -102,12 +109,15 @@ <widget class="QDoubleSpinBox" name="maWindowSizeSpinBox" /> </item> <item> - <widget class="QCheckBox" name="selectAcksCheckBox"> + <widget class="QCheckBox" name="selectSACKsCheckBox"> <property name="toolTip"> - <string>Allow ACKs as well as data packets to be selected by clicking on the graph</string> + <string>Allow SACK segments as well as data packets to be selected by clicking on the graph</string> </property> <property name="text"> - <string>select ACKs</string> + <string>select SACKs</string> + </property> + <property name="focusPolicy"> + <enum>Qt::TabFocus</enum> </property> </widget> </item> @@ -166,6 +176,9 @@ <property name="checkable"> <bool>true</bool> </property> + <property name="focusPolicy"> + <enum>Qt::TabFocus</enum> + </property> <attribute name="buttonGroup"> <string notr="true">mouseButtonGroup</string> </attribute> @@ -182,6 +195,9 @@ <property name="checkable"> <bool>true</bool> </property> + <property name="focusPolicy"> + <enum>Qt::TabFocus</enum> + </property> <attribute name="buttonGroup"> <string notr="true">mouseButtonGroup</string> </attribute> |