diff options
| author | Guy Harris <guy@alum.mit.edu> | 2016-09-02 13:30:28 -0700 |
|---|---|---|
| committer | Guy Harris <guy@alum.mit.edu> | 2016-09-02 20:33:15 +0000 |
| commit | df3bf9ca796dc2474c55c87f0ff8cb4eab63d2f6 (patch) | |
| tree | 028fe35f4c79754e0a35a1ecec44494713c082e0 /ui/qt/wireshark_application.cpp | |
| parent | 770aaf1dde2c57687beb0ebe9a3af9003c3c2c14 (diff) | |
| download | wireshark-df3bf9ca796dc2474c55c87f0ff8cb4eab63d2f6.tar.gz | |
Note that not all UN*X file systems are case-sensitive.
Expand a comment to suggest what we should probably do on macOS.
Change-Id: Ic18afe5d1b165dbb27b5f0f5ff3ff9a33835a0f4
Reviewed-on: https://code.wireshark.org/review/17470
Reviewed-by: Guy Harris <guy@alum.mit.edu>
Diffstat (limited to 'ui/qt/wireshark_application.cpp')
| -rw-r--r-- | ui/qt/wireshark_application.cpp | 9 |
1 files changed, 8 insertions, 1 deletions
diff --git a/ui/qt/wireshark_application.cpp b/ui/qt/wireshark_application.cpp index cf4f91dac5..2a4f06dbc4 100644 --- a/ui/qt/wireshark_application.cpp +++ b/ui/qt/wireshark_application.cpp @@ -157,7 +157,14 @@ add_menu_recent_capture_file(const gchar *cf_name) { /* do a case insensitive compare on win32 */ ri->filename.compare(normalized_cf_name, Qt::CaseInsensitive) == 0 || #else /* _WIN32 */ - /* do a case sensitive compare on unix */ + /* + * Do a case sensitive compare on UN*Xes. + * + * XXX - on UN*Xes such as macOS, where you can use pathconf() + * to check whether a given file system is case-sensitive or + * not, we should check whether this particular file system + * is case-sensitive and do the appropriate comparison. + */ ri->filename.compare(normalized_cf_name) == 0 || #endif cnt >= prefs.gui_recent_files_count_max) { |