Qt: various fixes to VoIP calls / RTP player windows

- Flush any remaining tapped packets before emitting captureFileRetapFinished().
  This ensures that all packets have been treated before returning from retapPackets().
- Remove VoIP tap listeners when captureFileRetapFinished() is emitted.
  This avoid summing stats each time the RTP player is opened, leading to wrong
  information in VoIP calls window
- Change voip_calls_tapinfo_t redraw member from a boolean to bitmap so as to identify
  which tap should call the tapinfo->tap_draw() callback. This allows fixing a race condition
  where the RTP player can be empty in Qt UI
- Reset some more statistics in voip_calls_reset_all_taps()

Change-Id: Ie7681702c81d338185c1813f2d340a437edf3a04
Reviewed-on: https://code.wireshark.org/review/12474
Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Anders Broman <a.broman58@gmail.com>

1 files changed, 2 insertions, 2 deletions

diff --git a/ui/voip_calls.h b/ui/voip_calls.h
index dbab87e2b5..193d0dd6c7 100644
--- a/ui/voip_calls.h
+++ b/ui/voip_calls.h
@@ -224,7 +224,7 @@ typedef struct _voip_calls_tapinfo {
     gint32                actrace_trunk;
     gint32                actrace_direction;
     flow_show_options     fs_option;
-    gboolean              redraw;
+    guint32               redraw;
 } voip_calls_tapinfo_t;
 
 #if 0
@@ -234,7 +234,7 @@ typedef struct _voip_calls_tapinfo {
     g_free(VOIP_CALLS_DEBUG_MSG); \
 }
 #else
-#define VOIP_CALLS_DEBUG()
+#define VOIP_CALLS_DEBUG(...)
 #endif
 
 /****************************************************************************/