diff options
author | Michael Mann <mmann78@netscape.net> | 2015-09-11 17:41:13 -0400 |
---|---|---|
committer | Michael Mann <mmann78@netscape.net> | 2015-09-15 02:20:13 +0000 |
commit | 51360b538016523bb2d2670c7bcb51f127a757e7 (patch) | |
tree | f390e21736bbc9711a4e97cc9cd5c00ed34c1ec0 /ui | |
parent | aebc99a49c325fa26040cd8bf4b8342a49b541e4 (diff) | |
download | wireshark-51360b538016523bb2d2670c7bcb51f127a757e7.tar.gz |
Eliminate proto_tree_add_text from odds and ends.
A few calls in the epan directory and comments in the ui directory
Change-Id: Ia8f8830ac6909ab94d3a03283bfd173456bc9718
Reviewed-on: https://code.wireshark.org/review/10492
Petri-Dish: Michael Mann <mmann78@netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Michael Mann <mmann78@netscape.net>
Diffstat (limited to 'ui')
-rw-r--r-- | ui/gtk/main.c | 9 | ||||
-rw-r--r-- | ui/qt/proto_tree.cpp | 9 |
2 files changed, 8 insertions, 10 deletions
diff --git a/ui/gtk/main.c b/ui/gtk/main.c index cf6e829a05..721f942e53 100644 --- a/ui/gtk/main.c +++ b/ui/gtk/main.c @@ -874,7 +874,7 @@ tree_view_selection_changed_cb(GtkTreeSelection *sel, gpointer user_data _U_) } else { /* * Don't show anything if the field name is zero-length; - * the pseudo-field for "proto_tree_add_text()" is such + * the pseudo-field for text-only items is such * a field, and we don't want "Text (text)" showing up * on the status line if you've selected such a field. * @@ -886,10 +886,9 @@ tree_view_selection_changed_cb(GtkTreeSelection *sel, gpointer user_data _U_) * but we'd have to add checks for null pointers in some * places if we did that. * - * Or perhaps protocol tree items added with - * "proto_tree_add_text()" should have -1 as the field index, - * with no pseudo-field being used, but that might also - * require special checks for -1 to be added. + * Or perhaps text-only items should have -1 as the field + * index, with no pseudo-field being used, but that might + * also require special checks for -1 to be added. */ statusbar_push_field_msg("%s", ""); } diff --git a/ui/qt/proto_tree.cpp b/ui/qt/proto_tree.cpp index 961cf577e0..20f1e0e8e5 100644 --- a/ui/qt/proto_tree.cpp +++ b/ui/qt/proto_tree.cpp @@ -392,7 +392,7 @@ void ProtoTree::updateSelectionStatus(QTreeWidgetItem* item) { } // else the GTK+ version pushes an empty string as described below. /* * Don't show anything if the field name is zero-length; - * the pseudo-field for "proto_tree_add_text()" is such + * the pseudo-field for text-only items is such * a field, and we don't want "Text (text)" showing up * on the status line if you've selected such a field. * @@ -404,10 +404,9 @@ void ProtoTree::updateSelectionStatus(QTreeWidgetItem* item) { * but we'd have to add checks for null pointers in some * places if we did that. * - * Or perhaps protocol tree items added with - * "proto_tree_add_text()" should have -1 as the field index, - * with no pseudo-field being used, but that might also - * require special checks for -1 to be added. + * Or perhaps text-only items should have -1 as the field + * index, with no pseudo-field being used, but that might + * also require special checks for -1 to be added. */ } else { |