diff options
author | João Valverde <joao.valverde@tecnico.ulisboa.pt> | 2015-11-27 02:28:17 +0000 |
---|---|---|
committer | João Valverde <j@v6e.pt> | 2016-01-28 18:13:48 +0000 |
commit | 265a41e14da6b3ebf1e49e726eee62d1372110bf (patch) | |
tree | f1a524f8e66ebd43691de84649f231f32ee125f6 /wiretap/Makefile.am | |
parent | 97a1a50e200a6c50e0014dde7e8ec932c30190a1 (diff) | |
download | wireshark-265a41e14da6b3ebf1e49e726eee62d1372110bf.tar.gz |
autotools: Don't use "user variables" to set build flags
GNU coding standards recommend against it and automake is designed
around it.
This allows overriding the global build flags using AM_CFLAGS, etc.,
or per object flags, something that is difficult or impossible currently
because of automake precedence rules.
Change-Id: I3f1ea12e560af5a46b2f04b342b1882bbf123f12
Reviewed-on: https://code.wireshark.org/review/13455
Petri-Dish: João Valverde <j@v6e.pt>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: João Valverde <j@v6e.pt>
Diffstat (limited to 'wiretap/Makefile.am')
-rw-r--r-- | wiretap/Makefile.am | 17 |
1 files changed, 4 insertions, 13 deletions
diff --git a/wiretap/Makefile.am b/wiretap/Makefile.am index 51af38caa3..05d60eca60 100644 --- a/wiretap/Makefile.am +++ b/wiretap/Makefile.am @@ -19,25 +19,18 @@ # along with this program; if not, write to the Free Software # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. -include ../Makefile.am.inc +include Makefile.common +include $(top_srcdir)/Makefile.am.inc ACLOCAL_AMFLAGS = `../aclocal-flags` -include Makefile.common +AM_CPPFLAGS += -DWS_BUILD_DLL noinst_LTLIBRARIES = libwiretap_generated.la lib_LTLIBRARIES = libwiretap.la # http://www.gnu.org/software/libtool/manual/html_node/Updating-version-info.html libwiretap_la_LDFLAGS = -version-info 0:0:0 @LDFLAGS_SHAREDLIB@ -AM_NON_GENERATED_CFLAGS =-DWS_BUILD_DLL - -if HAVE_WARNINGS_AS_ERRORS -AM_NON_GENERATED_CFLAGS += -Werror -endif - -AM_CPPFLAGS = -I$(srcdir)/.. - CLEANFILES = \ libwiretap.a \ libwiretap.la \ @@ -56,10 +49,10 @@ MAINTAINERCLEANFILES = \ libwiretap_la_SOURCES = \ $(NONGENERATED_C_FILES) \ $(NONGENERATED_HEADER_FILES) -libwiretap_la_CFLAGS = $(AM_NON_GENERATED_CFLAGS) libwiretap_generated_la_SOURCES = \ $(GENERATED_C_FILES) +libwiretap_generated_la_CFLAGS = $(GENERATED_CFLAGS) EXTRA_DIST = \ README.airmagnet \ @@ -72,8 +65,6 @@ EXTRA_DIST = \ libwiretap_la_LIBADD = libwiretap_generated.la ${top_builddir}/wsutil/libwsutil.la $(GLIB_LIBS) libwiretap_la_DEPENDENCIES = libwiretap_generated.la ${top_builddir}/wsutil/libwsutil.la -RUNLEX = $(top_srcdir)/tools/runlex.sh - k12text_lex.h : k12text.c ascend_scanner_lex.h : ascend_scanner.c |