diff options
| author | Jeff Morriss <jeff.morriss.ws@gmail.com> | 2016-04-19 17:45:29 -0400 |
|---|---|---|
| committer | Jeff Morriss <jeff.morriss.ws@gmail.com> | 2016-04-28 19:01:26 +0000 |
| commit | c954b1cefca7a34e06c71bcf59a2a0ee75f7cb1d (patch) | |
| tree | d06499c3c7ae12ca791b75482f35eb3544ecbbbe /wiretap/file_access.c | |
| parent | 363507ea18e154d76654f0d811e89e041273f835 (diff) | |
| download | wireshark-c954b1cefca7a34e06c71bcf59a2a0ee75f7cb1d.tar.gz | |
Remind wiretap developers where else they need to register their file types.
Chances are they want to include the file extension in wiretap's list of
file extensions (for the File->Open dialog) as well as the various files
needed for integration with the various desktop environments that
Wireshark supports.
(I should have put this advice there years ago when creating the
freedesktop.org mime-package file.)
Add a comment to the mime-package file explaining its purpose, giving
a link to the specification, and talking about MIME types and the registration
thereof.
Change-Id: I60540bf88062b7a90653888534405f6aef4f657c
Reviewed-on: https://code.wireshark.org/review/15011
Reviewed-by: Jeff Morriss <jeff.morriss.ws@gmail.com>
Diffstat (limited to 'wiretap/file_access.c')
| -rw-r--r-- | wiretap/file_access.c | 11 |
1 files changed, 11 insertions, 0 deletions
diff --git a/wiretap/file_access.c b/wiretap/file_access.c index ac383ccc16..61653fc311 100644 --- a/wiretap/file_access.c +++ b/wiretap/file_access.c @@ -307,6 +307,17 @@ wtap_get_all_file_extensions_list(void) * type to interpret it as, if the file name has no extension, the * extension isn't sufficient to determine the appropriate file type, * or the extension is wrong. + * + * NOTE: when adding file formats to this list you may also want to add them + * to the following files so that the various desktop environments will + * know that Wireshark can open the file: + * 1) wireshark-mime-package.xml (for freedesktop.org environments) + * 2) packaging/macosx/Info.plist.in (for OS X) + * 3) packaging/nsis/AdditionalTasksPage.ini and packaging/nsis/common.nsh + * (for Windows) + * + * If your file format has an expected extension (e.g., ".pcap") then you + * should probably also add it to file_type_extensions_base[] (in this file). */ static struct open_info open_info_base[] = { { "Wireshark/tcpdump/... - pcap", OPEN_INFO_MAGIC, libpcap_open, "pcap", NULL, NULL }, |