Revert "Allow wtap_read() and wtap_seek_read() to return non-packet records."

This reverts commit c0c480d08c175eed4524ea9e73ec86298f468cf4.

A better way to do this is to have the record type be part of struct wtap_pkthdr; that keeps the metadata for the record together and requires fewer API changes.  That is in-progress.

Change-Id: Ic558f163a48e2c6d0df7f55e81a35a5e24b53bc6
Reviewed-on: https://code.wireshark.org/review/1741
Reviewed-by: Guy Harris <guy@alum.mit.edu>

1 files changed, 9 insertions, 11 deletions

diff --git a/wiretap/mime_file.c b/wiretap/mime_file.c
index 0f8934a28e..2a7d8be0e4 100644
--- a/wiretap/mime_file.c
+++ b/wiretap/mime_file.c
@@ -94,7 +94,7 @@ static const mime_files_t magic_files[] = {
  */
 #define MAX_FILE_SIZE	(16*1024*1024)
 
-static int
+static gboolean
 mime_read_file(wtap *wth, FILE_T fh, struct wtap_pkthdr *phdr,
     Buffer *buf, int *err, gchar **err_info)
 {
@@ -102,7 +102,7 @@ mime_read_file(wtap *wth, FILE_T fh, struct wtap_pkthdr *phdr,
 	int packet_size;
 
 	if ((file_size = wtap_file_size(wth, err)) == -1)
-		return -1;
+		return FALSE;
 
 	if (file_size > MAX_FILE_SIZE) {
 		/*
@@ -112,7 +112,7 @@ mime_read_file(wtap *wth, FILE_T fh, struct wtap_pkthdr *phdr,
 		*err = WTAP_ERR_BAD_FILE;
 		*err_info = g_strdup_printf("mime_file: File has %" G_GINT64_MODIFIER "d-byte packet, bigger than maximum of %u",
 				file_size, MAX_FILE_SIZE);
-		return -1;
+		return FALSE;
 	}
 	packet_size = (int)file_size;
 
@@ -124,12 +124,10 @@ mime_read_file(wtap *wth, FILE_T fh, struct wtap_pkthdr *phdr,
 	phdr->ts.secs = 0;
 	phdr->ts.nsecs = 0;
 
-	if (!wtap_read_packet_bytes(fh, buf, packet_size, err, err_info))
-		return -1;
-	return REC_TYPE_PACKET;
+	return wtap_read_packet_bytes(fh, buf, packet_size, err, err_info);
 }
 
-static int
+static gboolean
 mime_read(wtap *wth, int *err, gchar **err_info, gint64 *data_offset)
 {
 	gint64 offset;
@@ -140,24 +138,24 @@ mime_read(wtap *wth, int *err, gchar **err_info, gint64 *data_offset)
 
 	/* there is only ever one packet */
 	if (offset != 0)
-		return -1;
+		return FALSE;
 
 	*data_offset = offset;
 
 	return mime_read_file(wth, wth->fh, &wth->phdr, wth->frame_buffer, err, err_info);
 }
 
-static int
+static gboolean
 mime_seek_read(wtap *wth, gint64 seek_off, struct wtap_pkthdr *phdr, Buffer *buf, int *err, gchar **err_info)
 {
 	/* there is only one packet */
 	if (seek_off > 0) {
 		*err = 0;
-		return -1;
+		return FALSE;
 	}
 
 	if (file_seek(wth->random_fh, seek_off, SEEK_SET, err) == -1)
-		return -1;
+		return FALSE;
 
 	return mime_read_file(wth, wth->random_fh, phdr, buf, err, err_info);
 }