diff options
| author | Guy Harris <guy@alum.mit.edu> | 2017-03-09 20:20:20 -0800 |
|---|---|---|
| committer | Guy Harris <guy@alum.mit.edu> | 2017-03-10 04:21:05 +0000 |
| commit | c2e74c5fc2cf9c0f6d85c2e6ce5bcb0cfb777b26 (patch) | |
| tree | c73c286aebf4afcb15507393ac7c34d73846a541 /wiretap | |
| parent | fe285c640b6279fdb9920bb79b0494ac87cb0e32 (diff) | |
| download | wireshark-c2e74c5fc2cf9c0f6d85c2e6ce5bcb0cfb777b26.tar.gz | |
Don't cast to a too-large size.
The maximum record length is 255*128 + 127 = 32767; that fits in a
guint32, which is large enough to support the biggest packet we'd ever
support without stretching several size values to 64 bits.
It's not a size of an object in memory, so it doesn't have to be a
size_t, and a size_t could be too large to fit in the record sizes we're
using.
Just cast to guint32.
Change-Id: Ie664fda3ce9945893fd992bbb9a81a5d632a3fcb
Reviewed-on: https://code.wireshark.org/review/20479
Reviewed-by: Guy Harris <guy@alum.mit.edu>
Diffstat (limited to 'wiretap')
| -rw-r--r-- | wiretap/netscaler.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/wiretap/netscaler.c b/wiretap/netscaler.c index dd9ee51bb8..065d8e41a1 100644 --- a/wiretap/netscaler.c +++ b/wiretap/netscaler.c @@ -856,7 +856,7 @@ nspm_signature_version(wtap *wth, gchar *nstrace_buf, gint32 len) #define nspr_getv10recordsize(hdp) (pletoh16(&(hdp)->nsprRecordSize)) #define nspr_getv20recordtype(hdp) ((hdp)->phd_RecordType) #define nspr_getv20recordsize(hdp) \ - (size_t)(((hdp)->phd_RecordSizeLow & NSPR_V20RECORDSIZE_2BYTES)? \ + (guint32)(((hdp)->phd_RecordSizeLow & NSPR_V20RECORDSIZE_2BYTES)? \ (((hdp)->phd_RecordSizeHigh * NSPR_V20RECORDSIZE_2BYTES)+ \ ((hdp)->phd_RecordSizeLow & ~NSPR_V20RECORDSIZE_2BYTES)) : \ (hdp)->phd_RecordSizeLow) |