summaryrefslogtreecommitdiff
path: root/ws_version_info.c
diff options
context:
space:
mode:
authorGerald Combs <gerald@wireshark.org>2016-08-19 13:59:49 -0700
committerGerald Combs <gerald@wireshark.org>2016-08-19 21:19:19 +0000
commit7cfb8b81f9a93c521f84a6f04c8e6e4f2b5db909 (patch)
tree8c347f4463d159c58312948cb06cd659a04d3d4f /ws_version_info.c
parentf52ce404593575cbc57903b46811007cbf89618a (diff)
downloadwireshark-7cfb8b81f9a93c521f84a6f04c8e6e4f2b5db909.tar.gz
Answer a locale question in a comment.
Change-Id: If2c287ed8d2a3b518ceff891f1e6d995d7a7daad Reviewed-on: https://code.wireshark.org/review/17182 Reviewed-by: Gerald Combs <gerald@wireshark.org>
Diffstat (limited to 'ws_version_info.c')
-rw-r--r--ws_version_info.c10
1 files changed, 3 insertions, 7 deletions
diff --git a/ws_version_info.c b/ws_version_info.c
index 6f7e7fb40d..036956aa7b 100644
--- a/ws_version_info.c
+++ b/ws_version_info.c
@@ -334,13 +334,9 @@ get_runtime_version_info(void (*additional_info)(GString *))
* it doesn't happen to match the settings of any of the
* locale environment variables.
*
- * XXX - what happens on Windows? If nobody's explicitly
- * overridden any of the environment variables, does this
- * reflect the locale settings in the OS? If so, does
- * that include the code page? (We're not using UTF-16
- * for output to files or the console; using code page
- * 65001, i.e. UTF-8, as your system code page probably
- * works best with Wireshark.)
+ * On Windows get_locale returns the full language, country
+ * name, and code page, e.g. "English_United States.1252":
+ * https://msdn.microsoft.com/en-us/library/x99tb11d.aspx
*/
if ((lang = get_locale()) != NULL) {
g_string_append_printf(str, ", with locale %s", lang);