summaryrefslogtreecommitdiff
AgeCommit message (Collapse)AuthorFilesLines
2011-11-16Get rid of unnecessary assignment (the code below it always assigns aGuy Harris1-1/+0
value to the variable). Praise be to Clang Cat. svn path=/trunk/; revision=39877
2011-11-16Don't set variables if we don't look at them later. All praise ClangGuy Harris1-3/+0
Cat. svn path=/trunk/; revision=39876
2011-11-16Add Jakob Hirsch; Fix bad formatting which screwed up AUTHORS display.Bill Meier1-1/+7
svn path=/trunk/; revision=39875
2011-11-16Cleanup & reformatting: whitespace & long-lines.Bill Meier1-135/+168
svn path=/trunk/; revision=39874
2011-11-16Thou shalt not use proto_tree_add_string() with an FT_BYTES field.Guy Harris1-2/+3
svn path=/trunk/; revision=39873
2011-11-16Delete pointless orig_offset variable, initialize speech_data_len[], use ↵Chris Maynard1-8/+7
tvb_reported_length() instead of tvb_length(), and protect against a possible buffer overflow. This should fix the Clang warning, "packet-evrc.c:364:41: warning: The right operand of '>=' is a garbage value", among other things. svn path=/trunk/; revision=39872
2011-11-16Fix indentation.Guy Harris1-1/+1
svn path=/trunk/; revision=39871
2011-11-15tvb_[reported_]length_remaining can return -1Bill Meier8-9/+9
svn path=/trunk/; revision=39870
2011-11-15Remove unneeded #includeBill Meier1-2/+2
svn path=/trunk/; revision=39869
2011-11-15(Trivial) Reformat some long lines & do some whitespace cleanup.Bill Meier1-22/+29
svn path=/trunk/; revision=39868
2011-11-15Check the return value of dissect_sip_name_addr_or_addr_spec()Anders Broman1-1/+6
Should fix the recent fuzz failures. Thanks Chris for isolating the offending packet. svn path=/trunk/; revision=39867
2011-11-15Squelch a warning. (This code probably needs a review; we really need aGuy Harris1-0/+1
better general framework for parsing text-based protocols.) svn path=/trunk/; revision=39866
2011-11-15Rename channel_type enums to avoid possible naming conflicts.Chris Maynard1-40/+41
svn path=/trunk/; revision=39865
2011-11-15More indentation cleanup.Guy Harris1-11/+11
svn path=/trunk/; revision=39864
2011-11-15Clean up indentation.Guy Harris1-48/+48
svn path=/trunk/; revision=39863
2011-11-15packet-sip.c:1469: warning: unused variable 'contact_param_end_offset'Anders Broman1-1/+1
svn path=/trunk/; revision=39862
2011-11-15Restore dissection of contact parameters.Anders Broman1-22/+66
svn path=/trunk/; revision=39861
2011-11-15Remove unneeded #includes;Bill Meier1-12/+10
Move proto_reg_handoff...() to the end of the file as per convention. svn path=/trunk/; revision=39860
2011-11-15Move proto_reg_handoff...() to the end of the file as per convention;Bill Meier1-75/+73
Do other minor reformatting and cleanup. svn path=/trunk/; revision=39859
2011-11-15Add svn:executable to propsBill Meier2-0/+0
svn path=/trunk/; revision=39858
2011-11-15Set svn:mime-type to image/pngBill Meier0-0/+0
svn path=/trunk/; revision=39857
2011-11-15Set svn:mime-type to image/pngBill Meier0-0/+0
svn path=/trunk/; revision=39856
2011-11-15Set svn:mime-type to image/pngBill Meier0-0/+0
svn path=/trunk/; revision=39855
2011-11-15Set svn:mime-type to image/pngBill Meier0-0/+0
svn path=/trunk/; revision=39854
2011-11-15Set svn:mime-type to image/pngBill Meier0-0/+0
svn path=/trunk/; revision=39853
2011-11-15Append important details from LI and SURI trees to root item.Martin Mathieson1-16/+24
Show some SNs in the info column. svn path=/trunk/; revision=39852
2011-11-15Fix some propsBill Meier2-4/+7
svn path=/trunk/; revision=39851
2011-11-15Fix some svn propertiesBill Meier1-1/+1
svn path=/trunk/; revision=39850
2011-11-15Fix svn:keywords prop: 'svn:eol-style'->'Id'Bill Meier0-0/+0
svn path=/trunk/; revision=39849
2011-11-15Fix svn:keywords prop: 'svn:eol-style'->'Id'Bill Meier0-0/+0
svn path=/trunk/; revision=39848
2011-11-15Fix props: svn:keyword->svn:keywords; remove svn:executableBill Meier11-0/+0
svn path=/trunk/; revision=39847
2011-11-15UMTS RLC:Martin Mathieson2-12/+66
- add lookup for "unknown" channel type dissector (mode is known) - set length extent for SUFI root item - show data frames in the info column (at least for AM...) DCT: - call RLCDCH with "unknown" channel type (as don't know whether IP or RRC) - support R9 svn path=/trunk/; revision=39846
2011-11-15 Add svn:keywords and svn:eol-style propertiesAlexis La Goutte0-0/+0
svn path=/trunk/; revision=39845
2011-11-15Enhance CPHA dissectorAlexis La Goutte1-312/+202
* Remove struct and sizeof * Replace proto_tree_add_* by proto_tree_add_item * Replace CPHA function (report2str, opcode2str...) by standard Wireshark functions * and minor bug fix svn path=/trunk/; revision=39844
2011-11-15From Michael Mann:Anders Broman1-45/+43
Bugfixes for both Buildbot issues: 1. seg-fault with multiple_service_packet 2. infinite loop https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6519 svn path=/trunk/; revision=39843
2011-11-15From Michael Mann:Anders Broman1-1/+18
Make it possible to use TortoiseSVN's SubWCRev.exe to update svnversion.h https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5441 svn path=/trunk/; revision=39842
2011-11-15OK, *that's* what Clang Cat was going on about:Guy Harris1-1/+2
packet-dcerpc-pn-io.c:8438:17: warning: Although the value stored to 'prm_flag2' is used in the enclosing expression, the value is never actually read from 'prm_flag2' OK, thanks for telling me that, technically, prm_flag1 = prm_flag2 = 0; can be implemented by storing the 0 into prm_flag1 directly rather than storing 0 into prm_flag2 and copying it to prm_flag1. Yes, you can haz cheeseburger. I guess it would matter if we were actually depending on some side-effect of fetching prm_flag2, but we're not. Rewrite this one to squelch the complaint. svn path=/trunk/; revision=39841
2011-11-15Rewrite some odd code. Clang Cat does not want:Guy Harris1-2/+1
packet-reload.c:2875:13: warning: Although the value stored to 'local_offset' is used in the enclosing expression, the value is never actually read from 'local_offset' although as I read the C90 spec the code is doing pretty much what it should be doing and the rewritten code does the same thing. However, it's also a bit more complicated and harder to read than the rewritten code. svn path=/trunk/; revision=39840
2011-11-15At least as I read the code, there can be up to 3 receive channels (theGuy Harris2-7/+23
number of channels is XXX & 0x03, hence in the range 0-3. Thanks and a tip of the hat to Clang Cat for catching this. svn path=/trunk/; revision=39839
2011-11-15Get rid of the depth argument to dfilter_macro_apply(); have an internalGuy Harris3-114/+120
routine that does all the work and that takes a depth argumen, and an external routine that calls that internal routine with a depth argument of 0. The depth is only of use internally, to avoid infinite recursion. When recursing with that routine, pass depth+1 as the depth value, rather than passing depth and incrementing it afterwards; the latter doesn't prevent infinite recursion. (Thanks and a tip of the hat to Clang Cat for catching this.) Squelch some other (harmless) warnings from Clang Cat. Clean up indentation. svn path=/trunk/; revision=39838
2011-11-14Append each op name to the operations sub-tree so you don't necessarily have ↵Chris Maynard1-0/+2
to expand the tree to see which ops are present. I think it makes more sense to append the names here rather than at the top level which was done to resolve bug 6078, but for now, I leave them appended in both places. svn path=/trunk/; revision=39837
2011-11-14Remove uneeded #includes, forward refs & check_col();Bill Meier4-36/+23
tvb_reported_length_remaining() can return -1; Localize a variable. svn path=/trunk/; revision=39836
2011-11-14'guint8=tvb_get_guint8() + 2' can wrap. Use 'gint=...' instead. ditto for ↵Bill Meier1-53/+52
'gint16=...' Also: - remove unneeded #include; - Remove unneeded check_col(); - use val_to_str_const() in several cases. svn path=/trunk/; revision=39835
2011-11-14The Originator protocol identifier is not present in the "provisioning ↵Chris Maynard1-2/+4
actions operation -61", only the "session management operatin -60". Fixes https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6570. svn path=/trunk/; revision=39834
2011-11-14Add svn:keywords and svn:eol-style propertiesBill Meier0-0/+0
svn path=/trunk/; revision=39833
2011-11-14From Martin Kaiser:Anders Broman1-0/+24
DVB-CI / CI+ dissect X.509 certificates. https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6575 svn path=/trunk/; revision=39832
2011-11-14Do some more length checking to avoid a dissector bug error. Should fixGuy Harris2-7/+75
bug 6564. svn path=/trunk/; revision=39831
2011-11-14Very minor cleanup: remove some unneeded #includes & some trailing whitespaceBill Meier3-9/+6
svn path=/trunk/; revision=39830
2011-11-14[-Wunused-but-set-variable]Anders Broman6-19/+11
svn path=/trunk/; revision=39829
2011-11-14packet-sip.c:1412: warning: 'uri_param_end_offset' may be used uninitialized ↵Anders Broman1-1/+1
in this function svn path=/trunk/; revision=39828
generated by cgit v1.2.1 (git 2.18.0) at 2024-07-01 13:19:52 +0000