summaryrefslogtreecommitdiff
path: root/tools/checkhf.pl
AgeCommit message (Collapse)AuthorFilesLines
2017-04-08checkhf: handle C++-style commentsPeter Wu1-9/+21
"tools/checkhf.pl epan/dissectors/packet-umts_fp.c" gave this error: Complex regular subexpression recursion limit (32766) exceeded at tools/checkhf.pl line 273. This is caused by the comment "// ... Indicator's ..." which failed to match the single-quoted string and caused "catastrophic backtracking". Solution to fix this case is to disallow unescaped newlines (add "\n" to the negated character class). Additionally, add logic to remove C++-style comments for completeness. Tested against all epan/dissectors/packet-*.c files, the only difference in output is this umts_fp case, the running time has not regressed. Change-Id: I7b43e01e1580acf831c0485513135b613bb02e8b Reported-by: Joerg Mayer Reviewed-on: https://code.wireshark.org/review/20965 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-07-10Cleanup and extend the regex for matching expert info entries.Jeff Morriss1-19/+17
Match each entity in the structure explicitly rather than skipping a bunch at the end. This makes it possible to easily (and clearly) specify where we allow white space. Don't capture the event group and severity: we don't use them anyway. Don't put single character matches in []: that makes it hard to read (for me anyway). There's no need for both the "m"(ultiline) and "s"(ingle line) options. Nor the "o"optimize (make buggy) option. These same changes should/will be applied to the hf regex later. Change-Id: I3bf307dcd6432eb1a0c2b9aceea201f8403e08c0 Reviewed-on: https://code.wireshark.org/review/16313 Reviewed-by: Michael Mann <mmann78@netscape.net> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-07-03checkhf: Use colon as field separator for better readabilityJoão Valverde1-4/+4
Comma looks like a list when skimming quickly. Change-Id: Ic0ac1bc8746c70724d2279e3d725c5c9449b79d8 Reviewed-on: https://code.wireshark.org/review/16260 Reviewed-by: João Valverde <j@v6e.pt> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-06-06Add support in checkhf.pl for expert info.Michael Mann1-5/+158
Basically a copy/paste of the existing hf_ functionality, but looking for ei_ variables instead. Change-Id: Ic9a34f6bd5dee895fc858bb9631c00271a86486b Reviewed-on: https://code.wireshark.org/review/15717 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2015-03-25Replace HF_EMPTY and ETT_EMPTY with -1Michael Mann1-3/+2
Change-Id: If3e89f8e46edd4eef82037b6b348fd70a9a3033d Reviewed-on: https://code.wireshark.org/review/7811 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2014-08-25checkhf.pl: (Trivial) fix two typosBill Meier1-2/+2
Change-Id: I2a63127dcf819d671a4c814dcbd82b2dca5022d3 Reviewed-on: https://code.wireshark.org/review/3838 Reviewed-by: Bill Meier <wmeier@newsguy.com>
2014-04-05Rework debug_print_hash logic so that it's supported by older versions of perl.Michael Mann1-1/+2
Change-Id: I1720681dc367e01268ffbb1f31035464fa642496 Reviewed-on: https://code.wireshark.org/review/971 Reviewed-by: Michael Mann <mmann78@netscape.net> Tested-by: Michael Mann <mmann78@netscape.net>
2014-03-05(Trivial) Fix a typo.Bill Meier1-1/+1
Change-Id: Ib084b7e9d463c54fc836745833005b1456a82709 Reviewed-on: https://code.wireshark.org/review/518 Reviewed-by: Bill Meier <wmeier@newsguy.com> Tested-by: Bill Meier <wmeier@newsguy.com>
2014-02-14Remove $Id$ and other Subversion leftovers from the tools.Jeff Morriss1-2/+0
There are a few things in here which could still use attention. Don't regenerate anything now. Change-Id: I283c224d3523212144707fca3d6265916cb11792 Reviewed-on: https://code.wireshark.org/review/205 Reviewed-by: Jeff Morriss <jeff.morriss.ws@gmail.com>
2013-02-10Update a comment; tweak a RegEx.Bill Meier1-4/+3
svn path=/trunk/; revision=47612
2013-02-09Remove blank lines separately after removing comments rather than asBill Meier1-3/+2
part of the 'remove comments' regex. Fixes a bug introduced in SVN #47583 which broke '#if 0' handling. svn path=/trunk/; revision=47598
2013-02-09Cleanup: Ditch CamelCase; use braces around references.Bill Meier1-181/+184
svn path=/trunk/; revision=47585
2013-02-09Fix a syntax error which causes a compile errorBill Meier1-1/+1
(altho not in my version Cygwin Perl V5.14 for some reason). svn path=/trunk/; revision=47584
2013-02-09Tweaks to RegEx usage for consistency and performance (andBill Meier1-66/+72
to fix a monor bug or two). svn path=/trunk/; revision=47583
2013-02-08Fix code to delete blank lines to remove all blank lines;Bill Meier1-7/+7
Update some Perl usage. svn path=/trunk/; revision=47569
2013-02-07Add addition test to reduce false positives for 'ERROR: NO ARRAY: 'Bill Meier1-4/+46
Essentially: Detect when an hf_... var is effictively initialized via the use of proto_registrar_get_id_byname() or proto_get_id_by_filter_name() (instead of proto_register_field_array()). svn path=/trunk/; revision=47542
2013-02-07Add a hack to fix false positive 'unused ...' related to use of ..._add_oui().Bill Meier1-0/+32
svn path=/trunk/; revision=47536
2013-02-07Fix a few minor bugs;Bill Meier1-15/+15
Do some small tweaks for readability & consistency. svn path=/trunk/; revision=47532
2013-02-04Add checking to verify that global hf_... defs are referenced in hf[] entry ↵Bill Meier1-63/+61
in same file. (Commented out for now since a few false positives are currently generated). Fix a few minor bugs; Tweak the calling sequences for various subs. svn path=/trunk/; revision=47476
2013-02-03Improvements:Bill Meier1-20/+78
- Handle preprocessed (as well as original) .c source files. (Running checkhf on the source after it has been pre-processed should give few false positives). - Remove blank lines, comments & quoted text strings before doing the hf_... tests: reduces false positives/negatives. svn path=/trunk/; revision=47458
2013-01-28 Re-implemention of checkhf.pl:Bill Meier1-208/+397
Main objective: reduce the number of false positives. (Committed as a patch to the original checkhf.pl written by Joerg Mayer so as to keep the history for the original program). svn path=/trunk/; revision=47331
2013-01-25Handle hf_... definitions which are not static;Bill Meier1-3/+7
For .../dissectors/(non-generated dissectors): Reduces the number of "unused" false positives (and adds about 2 different false positives). svn path=/trunk/; revision=47280
2012-06-28Update Free Software Foundation address.Jakub Zawadzki1-1/+1
(COPYING will be updated in next commit) svn path=/trunk/; revision=43536
2010-10-31Add a few comments and return with an error code ifJörg Mayer1-4/+13
appropriate, that way the whole stuff gets scriptable. right now warnings are error code 0 (like completely fine code). svn path=/trunk/; revision=34730
2010-10-29Say that an hf_ variable is used if we find "variable = hf_variable".Jeff Morriss1-1/+15
Add some debug statements. Tweak one regexp to catch more hf_ variable uses. svn path=/trunk/; revision=34684
2010-10-22Fix detection of hf entries being used in the hf array where the opening braceJeff Morriss1-9/+7
is on the preceding line. There was code here to do it but it needed to be moved inside the preceding 'else' (in particular, before the 'next' sent us around the loop again). The bug was noticed by Alexis La Goutte in https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5329 svn path=/trunk/; revision=34623
2009-05-29Small comment fixesJörg Mayer1-4/+7
svn path=/trunk/; revision=28519
2006-05-28Ethereal->WiresharkAnders Broman1-2/+2
svn path=/trunk/; revision=18234
2006-05-21name changeRonnie Sahlberg1-2/+2
svn path=/trunk/; revision=18197
2005-09-18Small updateJörg Mayer1-23/+41
svn path=/trunk/; revision=15860
2005-08-29Add a tool to check the hf_ values.Jörg Mayer1-0/+196
svn path=/trunk/; revision=15611
generated by cgit v1.2.1 (git 2.18.0) at 2024-05-18 23:45:39 +0000