summaryrefslogtreecommitdiff
path: root/ui/gtk/file_dlg.c
AgeCommit message (Collapse)AuthorFilesLines
2017-04-05A bunch of "{Mac} OS X" -> "macOS" changes.Guy Harris1-3/+3
Avoid anachronisms, however; there was no "macOS 10.0" or even "OS X 10.0", for example. It was "Mac OS X" until 10.8 (although 10.7 was sometimes called "OS X" and sometimes called "Mac OS X"), and it was "OS X" from 10.8 to 10.11. Change-Id: Ie4a848997dcc6c45c2245c1fb84ec526032375c3 Reviewed-on: https://code.wireshark.org/review/20933 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2016-10-22Fix the #defines for the presence of structure names.Guy Harris1-5/+5
AC_CHECK_MEMBER() and AC_CHECK_MEMBERS() use a standard name for the {structurename} being the name of the structure type, complete with "struct" if a typedef wasn't used, and with all letters mapped to upper case, and with {membername} being the name of the structure member, with all letters mapped to upper case. check_struct_has_member() lets you choose the name; choose the same name that the autoconf macros use, and fix the code to check for them. Change-Id: Ifb3cf65e7e94907ad0a2f8aacca0c21a531f0c5b Reviewed-on: https://code.wireshark.org/review/18382 Petri-Dish: Guy Harris <guy@alum.mit.edu> Reviewed-by: Guy Harris <guy@alum.mit.edu>
2016-04-02Use AC_CHECK_MEMBERSJoão Valverde1-4/+4
Change-Id: I18779ad869c97a6ddd12e39fe2f7a1f7b0c8cf56 Reviewed-on: https://code.wireshark.org/review/14754 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: João Valverde <j@v6e.pt>
2016-03-29Remove an unused variable from both the Gtk and Qt UIs.Jeff Morriss1-9/+1
Change-Id: I4c7c5aeaa1fa452605cf02a5c86dfe161c451f65 Reviewed-on: https://code.wireshark.org/review/14654 Reviewed-by: Michael Mann <mmann78@netscape.net> Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Jeff Morriss <jeff.morriss.ws@gmail.com>
2016-03-11Remove the last remnants of U3 support.Gerald Combs1-11/+1
Change-Id: Ide4c177e67a77c5f9495b3b4c0f817f40e6dde30 Reviewed-on: https://code.wireshark.org/review/14425 Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Gerald Combs <gerald@wireshark.org>
2015-06-22gtk,qt: Fix minor buffer underrunPeter Wu1-1/+1
Avoid accessing the first byte before an empty dirname. No idea why this was not triggered before. Reproduced with an empty Wireshark profile and wireshark and wireshark-qt. Caught with ASAN. Change-Id: I44f8fdab03ad0f24e663df63a1c54567996a3dfc Reviewed-on: https://code.wireshark.org/review/9037 Reviewed-by: Peter Wu <peter@lekensteyn.nl>
2015-02-15ui/gtk/*.c: Add editor modelines; As needed: Fix indentationBill Meier1-0/+13
Change-Id: I8cd9d9fe5f12c284f46b8f725766f681faccd753 Reviewed-on: https://code.wireshark.org/review/7138 Reviewed-by: Bill Meier <wmeier@newsguy.com>
2014-03-04Remove all $Id$ from top of fileAlexis La Goutte1-2/+0
(Using sed : sed -i '/^ \* \$Id\$/,+1 d') Fix manually some typo (in export_object_dicom.c and crc16-plain.c) Change-Id: I4c1ae68d1c4afeace8cb195b53c715cf9e1227a8 Reviewed-on: https://code.wireshark.org/review/497 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2013-11-17Move the epan/filesystem.c routines to wsutil; they're not specific toGuy Harris1-1/+1
packet dissection, they're specific to the entire Wireshark suite of programs. svn path=/trunk/; revision=53377
2013-10-29Revert part of 52896 and (for now) all of 52935. As Jeff pointed out,Gerald Combs1-0/+11
the PortableApps version relies on U3_-prefixed environment variables. svn path=/trunk/; revision=52941
2013-10-28Remove some (but not all) U3 remnants.Gerald Combs1-11/+0
svn path=/trunk/; revision=52935
2013-10-11More ui/util.h includes.Gerald Combs1-0/+1
svn path=/trunk/; revision=52545
2013-06-21Cast away another implicit conversion not allowed in C++ warningStephen Fisher1-1/+1
svn path=/trunk/; revision=50109
2013-05-14Give file_selection_new() an argument to specify the parent window ofGuy Harris1-10/+12
the file selection dialog. Call gtk_file_chooser_set_do_overwrite_confirmation() in file_selection_new() for FILE_SELECTION_SAVE file selection dialogs, rather than doing it in the individual callers of file_selection_new(). Use gtk_dialog_set_alternative_button_order() in file_selection_new() to set the alternative button order, rather than using #ifdefs. Use file_selection_new() and file_selection_run() in the graph analysis code. (We should clean up other code that uses file_selection_new() to use file_selection_run(), and clean up other code that uses gtk_file_chooser_dialog_new() to use file_selection_new() and file_selection_run().) svn path=/trunk/; revision=49308
2013-03-21From beroset:Bill Meier1-3/+3
remove C++ incompatibilities https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8416 attachment #10404 Note: The following parts of the patch had been previously done: asn1/snmp/packet-snmp-template.c epan/dissectors/packet-snmp.c epan/dissectors/packet-x11.c Also; hostlist_table.c: code under '#ifdef HAVE_GEOIP' didn't compile and needed a few additional patches. svn path=/trunk/; revision=48447
2013-02-25it's ==> its & its ==> it's as needed.Bill Meier1-1/+1
In a few cases: Fix spelling; Clean up whitespace and formatting style. svn path=/trunk/; revision=47889
2012-12-22The Wireshark file icon makes more sense than a floppy disk[1]. SwitchGerald Combs1-1/+1
back to it and name it "Save" instead of "File". [1] http://www.hanselman.com/blog/TheFloppyDiskMeansSaveAnd14OtherOldPeopleIconsThatDontMakeSenseAnymore.aspx svn path=/trunk/; revision=46696
2012-12-22R46374 replaced too many GTK_STOCK_SAVEs. Put them back.Gerald Combs1-1/+1
svn path=/trunk/; revision=46690
2012-12-04Replace GTK_STOCK_SAVE with WIRESHARK_STOCK_FILE in a few places,Gerald Combs1-1/+2
including the GTK+ and Qt main toolbars. svn path=/trunk/; revision=46374
2012-09-20We always HAVE_CONFIG_H so don't bother checking whether we have it or not.Jeff Morriss1-3/+1
svn path=/trunk/; revision=45016
2012-06-28Update Free Software Foundation address.Jakub Zawadzki1-1/+1
(COPYING will be updated in next commit) svn path=/trunk/; revision=43536
2012-06-21We now need <epan/filesystem.h> regardless of whether we're being builtGuy Harris1-2/+0
on Win32 or not, as we need test_for_directory(). svn path=/trunk/; revision=43440
2012-06-21Move a bunch of common code in the file chooser dialog loops into aGuy Harris1-0/+123
routine to run a file chooser dialog. On Windows, add to that code to resolve shell links ("shortcuts"), adopted from the Sylpheed mail reader. (That code requires a pile of OLE stuff, so link with the OLE library.) Make it a bit easier to configure ui/gtk/capture_file_dlg.c to use GTK+ dialogs on Windows, but continue to default to using the Win32 dialogs, at least for now. svn path=/trunk/; revision=43439
2012-06-19The GTK+ file chooser already *includes* UI code to ask the user whetherGuy Harris1-107/+68
they want to overwrite an existing file; just use that. (The Win32 file chooser also does that itself.) Just do UI for "do you want to overwrite this {user-immutable,unwritable} file?". svn path=/trunk/; revision=43381
2012-06-19The file dialog run by file_selection_browse() is modal, so there willGuy Harris1-9/+0
only be one instance per "Browse" button up at a time - no need to check for one already being open. svn path=/trunk/; revision=43349
2012-06-04And do the same with the color filter import and export dialogs (whichGuy Harris1-3/+14
really don't belong here - they have nothing to do with capture files). Absorb the test for the target file's existence into file_target_exist_ui(). svn path=/trunk/; revision=43077
2012-06-04file_target_exist_ui() is used only on UN*Xes; on Win32, we'd use theGuy Harris1-0/+2
Windows file dialog, which has its own built-in version of the "do you want to overwrite that file?" dialog, and Notepad and WordPad, at least, just appear to error out if you try to overwrite a file with the read-only flag set, rather than asking whether you want to override that. svn path=/trunk/; revision=43072
2012-06-04Make the "Export Selected Packets As..." code path more like the "SaveGuy Harris1-0/+135
As..." code path. Extract the code for the "do you want to overwrite this file" and "OK, you do - are you aware it's {user-immutable, read-only}?" code paths into a common routine for use by both of those and, potentially, other save/export/etc. code paths in the future. For "Save As", allow us to save atop the current capture file, as that's just what "Save" does if there are unsaved changes, and "safe save" makes that work. *Don't* allow that for "Export Selected Packets As...", however. The file chooser is run as a modal dialog, so we don't need to worry about creating more than one of them or about the number of marked packets etc. being changed out from under us. Get rid of a bunch of static variables. svn path=/trunk/; revision=43060
2012-01-15Move gtk to ui/gtk.Jörg Mayer1-0/+258
This looses the last checkin to gtk, will add this manually back. svn path=/trunk/; revision=40518
generated by cgit v1.2.1 (git 2.18.0) at 2024-05-23 22:09:17 +0000