summaryrefslogtreecommitdiff
path: root/ui/qt/qcustomplot.cpp
AgeCommit message (Collapse)AuthorFilesLines
2017-02-28Qt: Fix -Wshorten-64-to-32 warningsStig Bjørlykke1-1/+1
Fix some warnings when building with -Wshorten-64-to-32 flag for C++ code. Fixes for warnings from QList, QTimer and QVector has been pushed upstream, so some time we may be able to enable this flag for C++. Change-Id: Iae7457f9afc469c63f3edbe23dbf272b5c6c9e5e Reviewed-on: https://code.wireshark.org/review/20310 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
2016-10-17Get rid of the trivial Q_UNUSED casesJoerg Mayer1-76/+33
Change-Id: Ia7ddde278158f3321eb4244189375bdd51c8976d Reviewed-on: https://code.wireshark.org/review/18227 Reviewed-by: Jörg Mayer <jmayer@loplof.de>
2016-08-06Remove old Qt code.Gerald Combs1-8/+0
Our minimum version has been 4.7 for a while. Remove dead QT_VERSION_CHECK code. Change-Id: Ia003c1aa4275eefdda707975774d886643ff1538 Reviewed-on: https://code.wireshark.org/review/16888 Reviewed-by: Gerald Combs <gerald@wireshark.org> Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-06-05Qt ui code: fix qreal type problems on ARM platformZdeněk Žamberský1-37/+37
fixing problems in qt ui code comming from the fact that qreal type is float on ARM platform and double on other platforms, which causes build errors on ARM (not all casts are probably strictly necessary) Bug: 12483 Change-Id: Ife5e6d3649a7ee1ad4e7eadffe9f4484ff2718de Reviewed-on: https://code.wireshark.org/review/15723 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2016-02-08QCP: Fix retina label calculations.Gerald Combs1-8/+16
The retina fixes in gb10bad1 and gb3f3d66 were incomplete and caused rendering problems in our axis labels. Handle the device pixel ratio in a couple of more places so that our axis rects are correctly sized. Add a switch (WS_ENABLE_DP_RATIO) to make it easy to turn scaling on and off. Change-Id: I633d94d633e0743be2a607c9a4cbb3409e9eed62 Ping-Bug: 11710 Reviewed-on: https://code.wireshark.org/review/13834 Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Gerald Combs <gerald@wireshark.org>
2016-01-24Qt io_graph: Use Interval value when generating Y-axis label or legendJim Young1-0/+37
The I/O Graph allows the user to choose from several different Y-axis units. Three of the selectable Y-axis units unconditionally imply a per-second time unit (/s) regardless of the actual I/O Graph Interval value selected. In addition the Y-axis label includes the “/s” as a suffix regardless of the current Interval value. This patch removes "/s" suffix from the Y-axis pick-list units. This patch also dynamically adds the selected Interval value to the Y-Axis label or alternatively as the first line of the legend box that is displayed if the various enabled graphs have differing Y-axis values. For readability the pick-list values for sub-second Interval values are changed to 1 ms, 10 ms and 100 ms from the original pick-list values of 0.001 sec, 0.01 sec and 0.1 sec respectively. To support adding a “Title” to the legend, the QCustomPlot widget is augmented with “Legend Title” source authored by “David” as posted at: http://www.qcustomplot.com/index.php/support/forum/443 Note: This patch changes the valid Y-axis unit values stored within the io_graphs preferences files. Any io_graphs files having entries with the now obsolete Y-Axis values of “Packets/s”, “Bytes/s” or “Bits/s“ will be silently upgraded to “Packets”, "Bytes" and "Bits" respectively when saved. Bug: 11855 Change-Id: I503ff6dc20b09d90f087342084fb0db6e0080c7f Reviewed-on: https://code.wireshark.org/review/12219 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Michael Mann <mmann78@netscape.net>
2015-12-15qt: add init values to make clang happy.Dario Lombardo1-8/+8
Found by clang analyzer. Change-Id: I04598e8e9fcb716b373d4b2f707de8f263ff36b0 Reviewed-on: https://code.wireshark.org/review/11029 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2015-10-22qt: remove leakDario Lombardo1-1/+5
Found by clang analyzer. Change-Id: If8bc72e1de276ae778ee3ac3e0dfc9dffa384c29 Reviewed-on: https://code.wireshark.org/review/11028 Reviewed-by: Martin Kaiser <wireshark@kaiser.cx> Reviewed-by: Michael Mann <mmann78@netscape.net>
2015-05-13QCustomPlot: fix division(or modulo) by zero found by Clang and Coverity ↵Alexis La Goutte1-3/+10
(CID 1159170 & 1159171) Try 2 Change-Id: I10c439ccd4b8e5ac24275332e35fb35ad95b8d1b Reviewed-on: https://code.wireshark.org/review/8447 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2015-05-07Revert "QCustomPlot: fix division(or modulo) by zero found by Clang and ↵Alexis La Goutte1-6/+2
Coverity (CID 1159170 & 1159171)" This reverts commit b394aa5f1e4ad030ab23d18b439e8f5c9eca9792. The patch don't fix this issue... Change-Id: I654933ec4ebebdef840f24ba20162f1f1a5321cc Reviewed-on: https://code.wireshark.org/review/8332 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2015-04-19QCustomPlot: fix division(or modulo) by zero found by Clang and Coverity ↵Alexis La Goutte1-2/+6
(CID 1159170 & 1159171) Change-Id: Iba9317436983bb4b3730be8b80e7b9c107ffc3a9 Reviewed-on: https://code.wireshark.org/review/8112 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2015-02-18Update Qt version checks.Gerald Combs1-3/+3
It looks like QPaintDevice::devicePixelRatio() was added in 5.1. Back out some debugging code. Change-Id: I40f19c0d7901ce95f587531983e5c6644daf64f4 Reviewed-on: https://code.wireshark.org/review/7226 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2015-02-18Fix QCustmPlot retina problems.Gerald Combs1-0/+21
Make sure our intermediate pixmaps have the same number of pixels as the screen. A merge request with the same changes has been made upstream. Change-Id: I19950181d52f347e3aa7f5abb6e9ad33a4097abf Reviewed-on: https://code.wireshark.org/review/7224 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2015-01-05Update to QCustomPlot 1.3.0Alexis La Goutte1-909/+2997
Reapply remove trailing whitespace and some spelling fixes Fix also a not ASCII caracter in qcustomplot.h Change-Id: Ibd5433015dd117f4d028c842a4add53041adbd11 Reviewed-on: https://code.wireshark.org/review/6275 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2014-03-23Update to QCustomPlot 1.2.0Alexis La Goutte1-3249/+5946
Reapply remove trailing whitespace and some spelling fixes MSCV warning are already fixed Fix also a not ASCII caracter in qcustomplot.h Change-Id: Ied6b0a4ad7397caea6b75fa56f4f2d6ea91d0472 Reviewed-on: https://code.wireshark.org/review/787 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2013-12-23From Ville Skyttä: Spelling FixesBill Meier1-6/+6
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9591 svn path=/trunk/; revision=54387
2013-12-03- Fix lots of "C:\wireshark\trunk\ui\qt\qcustomplot.cpp(16589) :Jörg Mayer1-1548/+1548
warning C4305: 'argument' : truncation from 'double' to 'float'" - Remove trailing whitespace svn path=/trunk/; revision=53768
2013-08-27Add TCP sequence number (Stevens-style) graphs.Gerald Combs1-0/+18675
Add the QCustomPlot widget. Thanks to Emanuel Eichhammer for granting a license change. Move some common code from ui/gtk/tcp_graph.c to ui/tap-tcp-stream.[ch]. Get rid of tcp_graph_selected_packet_enabled(). It was only used in the menu code and didn't match what we were doing elsewhere. Still quite a bit of work to do but it's a promising start. svn path=/trunk/; revision=51538