summaryrefslogtreecommitdiff
path: root/ui/qt/sctp_chunk_statistics_dialog.cpp
AgeCommit message (Collapse)AuthorFilesLines
2017-04-05A bunch of "{Mac} OS X" -> "macOS" changes.Guy Harris1-1/+1
Avoid anachronisms, however; there was no "macOS 10.0" or even "OS X 10.0", for example. It was "Mac OS X" until 10.8 (although 10.7 was sometimes called "OS X" and sometimes called "Mac OS X"), and it was "OS X" from 10.8 to 10.11. Change-Id: Ie4a848997dcc6c45c2245c1fb84ec526032375c3 Reviewed-on: https://code.wireshark.org/review/20933 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2017-03-27Fix "warning C6246: Local declaration hides declaration of the same name in ↵Michael Mann1-9/+9
outer scope" warnings Change-Id: I0dbf8d0236b163da568a173ccedc3072bd039caa Reviewed-on: https://code.wireshark.org/review/20739 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-01-22Internalize struct preferenceMichael Mann1-6/+6
Move "struct preference" into prefs.c, essentially creating a "private" structure to handle preferences. The 2 motivating factors were: 1. Better memory management so that clients/users of API don't have to worry about it. 2. Hide the ugliness of the union stuff and make it transparent to the API. A few bugs related to preference <-> Decode As integration were fixed while in the neighborhood. Change-Id: I509b9a236235d066b139c98222b701475e0ed365 Reviewed-on: https://code.wireshark.org/review/19578 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-10-24Qt: use ws_strtou function in sctp_chunk_statistics_dialog.Dario Lombardo1-1/+4
Change-Id: Iffa2d633ef7a0f636c595fb05ad1790d1ea61df0 Reviewed-on: https://code.wireshark.org/review/18402 Petri-Dish: Dario Lombardo <lomato@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-01-23ui: Code cleanupStig Bjørlykke1-3/+3
Fixed code layout to use common style in the file. Mostly whitespace changes. Change-Id: Id37b57717a9e26248fad07322dff09b1d1f45ac2 Reviewed-on: https://code.wireshark.org/review/13504 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2015-12-07SCTP: Fix warning found by PVS Studioruengeler1-1/+3
Change-Id: I713eb6eff3681573baf77274847a32a4cc6b9ee0 Reviewed-on: https://code.wireshark.org/review/12408 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2015-11-25qt: move file close (CID 1159303)Dario Lombardo1-2/+3
Change-Id: Ib21327babc77324313a1b3e2dd6ba0987a8fb333 Reviewed-on: https://code.wireshark.org/review/12144 Reviewed-by: Michael Mann <mmann78@netscape.net> Petri-Dish: Michael Mann <mmann78@netscape.net> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2015-08-26Don't emit app signals from dialogs.Gerald Combs1-0/+4
Emitting PacketDissectionChanged from a dialog on can render the main window unusable on OS X. A workaround for this was added to the preferences dialog in g8fc2327. Generalize the workaround and use it elsewhere. Fix the "Enabled Protocols" action name while we're here. Bug: 11361 Bug: 11448 Change-Id: I89e98daaaedc877d3b13b0d33b6f3be033e323d7 Reviewed-on: https://code.wireshark.org/review/10271 Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Gerald Combs <gerald@wireshark.org>
2015-08-26Qt SCTP: Changed prohibited APIsStig Bjørlykke1-6/+8
strcpy -> g_strlcpy sprintf ->g_snprintf Also initialize some temp variables. Change-Id: I4d2fa1b0325c6e59aa13ebeb0d9c25d5ff7c4d9c Reviewed-on: https://code.wireshark.org/review/10252 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2015-06-25Qt: use <> for including the generated ui_*.h filesMartin Kaiser1-1/+1
this should make Visual Studio pick up the generated include files from the build directory instead of the source directory (which may contain lefovers from an in-tree build) Change-Id: Ie3de4cdd85a2865e203118a42ab10f443372f03b Reviewed-on: https://code.wireshark.org/review/9129 Petri-Dish: Martin Kaiser <wireshark@kaiser.cx> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2015-01-13uat_load() and uat_save() return a success indication; use it.Guy Harris1-3/+3
Instead of always ignoring the return value, always check it, and only report an error if it returns FALSE. (Alternative: have it return NULL on success and a pointer to a g_malloc()ed string on failure.) Fix a comment while we're at it. Change-Id: Icb72c9f47775b6552e3eb4fe5ddcc85482bfb5fb Reviewed-on: https://code.wireshark.org/review/6528 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2015-01-12Remove emem APIs from UAT functionality.Michael Mann1-1/+2
Change-Id: I009c09f25d170e5c9aaaef713eaacb3252817856 Reviewed-on: https://code.wireshark.org/review/6460 Petri-Dish: Michael Mann <mmann78@netscape.net> Reviewed-by: Evan Huus <eapache@gmail.com> Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2014-11-21Add minimize and maximize buttons to the SCTP analysis windows.Irene Ruengeler1-0/+5
As suggested by Jeff Morriss. Change-Id: Ibe2d30c31d51ab92377d64068527b424a92e8a64 Reviewed-on: https://code.wireshark.org/review/5361 Petri-Dish: Jeff Morriss <jeff.morriss.ws@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Jeff Morriss <jeff.morriss.ws@gmail.com> Tested-by: Jeff Morriss <jeff.morriss.ws@gmail.com> Reviewed-by: Evan Huus <eapache@gmail.com>
2014-09-07Squelch a compiler warning and get rid of an unnecessary variable.Guy Harris1-2/+1
Just use "sizeof line" for the size of that array; don't have a separate variable with the number of elements of the array (which at least is equal to the size of the array, as it's an array of char), as that means that you have to remember to change both of them. Then cast "sizeof line" to int, as the second argument to fgets() is an int, not a size_t (fgets(), as I remember, existed before size_t). Change-Id: I3c65774527f4fcd824d7ae39208ab6e8e33eb9b4 Reviewed-on: https://code.wireshark.org/review/4023 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2014-03-04Remove all $Id$ from top of fileAlexis La Goutte1-2/+0
(Using sed : sed -i '/^ \* \$Id\$/,+1 d') Fix manually some typo (in export_object_dicom.c and crc16-plain.c) Change-Id: I4c1ae68d1c4afeace8cb195b53c715cf9e1227a8 Reviewed-on: https://code.wireshark.org/review/497 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2013-12-18Ignore the first line of the chunk statistics file.Irene Rüngeler1-18/+6
svn path=/trunk/; revision=54210
2013-12-17Make Ubuntu Buildbot happyAlexis La Goutte1-1/+1
Fix following error: ../../../ui/qt/sctp_chunk_statistics_dialog.cpp: In member function ‘void SCTPChunkStatisticsDialog::fillTable(bool)’: ../../../ui/qt/sctp_chunk_statistics_dialog.cpp:145:29: error: ignoring return value of ‘char* fgets(char*, int, FILE*)’, declared with attribute warn_unused_result [-Werror=unused-result] svn path=/trunk/; revision=54188
2013-12-17Make translatable ready SCTP Graph for QtAlexis La Goutte1-7/+7
svn path=/trunk/; revision=54170
2013-12-17Fill the chunk statistics. Read line with fgets instead of getline.Irene Rüngeler1-16/+8
svn path=/trunk/; revision=54166
2013-12-13May this silences a warning of code that will go out next week.Michael Tüxen1-1/+4
svn path=/trunk/; revision=54042
2013-12-13Try to silence a warning due to a temporary workaround.Michael Tüxen1-0/+2
svn path=/trunk/; revision=54040
2013-12-13Add Copyright and modelines (Fix also indent to use 4 spaces)Alexis La Goutte1-0/+36
svn path=/trunk/; revision=54038
2013-12-13Fix typo.Irene Rüngeler1-0/+2
svn path=/trunk/; revision=54036
2013-12-13Fix build when use Qt4Alexis La Goutte1-0/+6
ui/qt/sctp_chunk_statistics_dialog.cpp:16:40: error: ‘class QHeaderView’ has no member named ‘setSectionsClickable’ ui/qt/sctp_chunk_statistics_dialog.cpp:17:40: error: ‘class QHeaderView’ has no member named ‘setSectionsMovable’ svn path=/trunk/; revision=54034
2013-12-13Add dialogs and graphs to analyse SCTP behavior similar to the GTK version.Irene Rüngeler1-0/+288
svn path=/trunk/; revision=54026