summaryrefslogtreecommitdiff
path: root/ui/qt/sequence_diagram.cpp
AgeCommit message (Collapse)AuthorFilesLines
2017-03-27Fix "warning C6246: Local declaration hides declaration of the same name in ↵Michael Mann1-1/+0
outer scope" warnings Change-Id: I0dbf8d0236b163da568a173ccedc3072bd039caa Reviewed-on: https://code.wireshark.org/review/20739 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-10-02Qt: Only color sequence analysis items having color filterStig Bjørlykke1-3/+7
Packets without a color filter will end up with fg_color and bg_color = 0, so avoid drawing all in black. Bug: 12065 Change-Id: I76bcabcfa3281fcece08f1b2af66274c808b80bb Reviewed-on: https://code.wireshark.org/review/18018 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
2016-06-01Qt: Color _ANY and _TCP sequence analysis items.Gerald Combs1-1/+4
For SEQ_ANALYSIS_ANY, color each sequence diagram item according to its associated packet. For SEQ_ANALYSIS_TCP, color each item according to its stream. Bug: 12065 Change-Id: Ib43490fe55039fbcfa793223b5850233a2694a26 Reviewed-on: https://code.wireshark.org/review/15651 Reviewed-by: Gerald Combs <gerald@wireshark.org> Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-05-27Qt: Sequence dialog navigation updates.Gerald Combs1-0/+1
Clean up the next / previous logic a bit. If the selected item is out of range, move it in-range. Change-Id: Idd5f83e7f4ccf960500f261e1c2292da6cecab57 Reviewed-on: https://code.wireshark.org/review/15591 Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Gerald Combs <gerald@wireshark.org>
2016-05-26Qt: Don't use QMap::first or ::lastGerald Combs1-2/+7
QMap::first and ::last were added in Qt 5.2. Change-Id: I63bbb384aa75910bb96d8f75185ae90444b6c127 Reviewed-on: https://code.wireshark.org/review/15576 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2016-05-26Qt: Add next / previous sequence shortcuts.Gerald Combs1-2/+45
Add next (N) and previous (P) keyboard shortcuts. The GTK+ UI uses the down and up keys, but we're already using those for panning the Y axis. Add a scroll margin when using N and P. Add mouse wheel and trackpad support. Disable mouse dragging for now until we figure out how to limit it to our axis boundaries. Ping-Bug: 12419 Change-Id: I292319928db365206277bf2bb3e42e14ef811ff0 Reviewed-on: https://code.wireshark.org/review/15559 Reviewed-by: Gerald Combs <gerald@wireshark.org> Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-05-25Qt: Add Time and Comment labels to the sequence diagram.Gerald Combs1-30/+39
Add "Time" and "Comment" labels to the sequence diagram similar to the GTK+ UI. Draw a border around the diagram as well. Widen the default spacing and set it to a simple em-width multiple. Fix our port number alignment. Copy over the sequence diagram colors from the GTK+ UI and add them to ColorUtils. Color sequences according to their respective conversation numbers. To do: - Add zoom. Ping-Bug: 12419 Change-Id: I3f9b4ffbfcc34aae1c38e303cd36ff207be247b1 Reviewed-on: https://code.wireshark.org/review/15554 Reviewed-by: Gerald Combs <gerald@wireshark.org> Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-02-08Qt: Restore sequence diagram labels, other fixes.Gerald Combs1-2/+8
SequenceDiagram implements time, address, and comment labels using QCPAxis::setTickVector and QCPAxis::setTickVectorLabels. It also calls QCPAxis::setTicks(false) so that we don't draw tick marks. It appears that doing so also disables the labels themselves in our current version of QCP. Set the tick pen to Qt::NoPen instead. Only draw node lines where we have nodes. Add notes about a retina issue and the need for zooming. Bug: 11710 Change-Id: I88c30a1ddcd29832f86b1ca8c018c7fa6b6d64a7 Reviewed-on: https://code.wireshark.org/review/13781 Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Gerald Combs <gerald@wireshark.org>
2015-11-29Make address_to_display() use proper (non-)constnessJoão Valverde1-1/+1
Don't return allocated memory as a const pointer. Fixes multiple [-Wcast-qual] warnings. Change-Id: Ie9ceac27fa2a5eba41a5392ac983ff28c3939239 Reviewed-on: https://code.wireshark.org/review/12267 Petri-Dish: Guy Harris <guy@alum.mit.edu> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2015-11-01Qt: do not draw sequence analysis items with a display status set to falsePascal Quantin1-8/+10
Change-Id: Ieff9d6838fcf5329c16df8b7d6367a4c6c3a5ee5 Reviewed-on: https://code.wireshark.org/review/11467 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2015-10-26Only store frame number and not a pointer to frame_data structure in ↵Pascal Quantin1-1/+1
seq_analysis_item_t Qt GUI allows to keep windows open after closing the capture file. Let's not access to freed memory. Bug: 11573 Change-Id: I9e70d818a4b228af319961ec512b6b9725792477 Reviewed-on: https://code.wireshark.org/review/11270 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Gerald Combs <gerald@wireshark.org>
2015-07-07Starting to get rid of Q_UNUSED declarations for unused function parameters.Joerg Mayer1-11/+4
The official C++ way is to leave out the variable name instead. This has the advantage to be reliable: In one case a variable declared unused was later used. Change-Id: I1c96636f7fa7a621d1594d1e9cacaec75c561faa Reviewed-on: https://code.wireshark.org/review/9532 Reviewed-by: Jörg Mayer <jmayer@loplof.de>
2015-03-06Qt: Fix a couple of resource leaks found by Coverity.Gerald Combs1-0/+5
Change-Id: Ic3156d8afc2fa237407f3893c34672b1306866fa Reviewed-on: https://code.wireshark.org/review/7420 Reviewed-by: Michael Mann <mmann78@netscape.net> Reviewed-by: Evan Huus <eapache@gmail.com>
2015-02-13Qt: More #include → forward declarations.Gerald Combs1-3/+5
Change-Id: Ib6de71f801cd3053374b6c867370acd594dcd396 Reviewed-on: https://code.wireshark.org/review/7089 Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Gerald Combs <gerald@wireshark.org>
2015-01-05Replace ep_display_to_address with wmem equivalent display_to_address.Michael Mann1-1/+5
Almost all instances require using "manual" memory management, but it gets some ep_ calls out of the GUI. Change-Id: Ifa7303766b08d09442ccf3d7063cbe061578ecd9 Reviewed-on: https://code.wireshark.org/review/6318 Reviewed-by: Michael Mann <mmann78@netscape.net>
2014-12-09Qt: Initial VoIP Calls dialog.Gerald Combs1-5/+4
Add Telephony menu items for VoIP Calls and SIP Flows. Put VoIP Calls at the top, since that seems to be the primary item. Add configure-time checks for QtMultimediaWidgets in anticipation of adding a VoIP playback dialog. Add an icon for the playback button. (Yes, I've been avoiding GNOME-level gratuitous icons so far but this is one of the rare occiasions where it makes sense.) Add a help link define for the VoIP calls dialog. Change-Id: I5d0799685c598ad9af76fe9667f8ea7d14b66050 Reviewed-on: https://code.wireshark.org/review/5674 Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Gerald Combs <gerald@wireshark.org>
2014-06-27Use GQueue for generating statisticsBalint Reczey1-1/+1
This makes reversing the list back and forth to keep adding data at O(n) complexity obsolete. Bug: 9696 Change-Id: Ice77328b8f6c5bf72bbfcfd82e08d09d4f986d3f Reviewed-on: https://code.wireshark.org/review/2571 Reviewed-by: Balint Reczey <balint@balintreczey.hu> Tested-by: Balint Reczey <balint@balintreczey.hu>
2014-04-19Some routine name changes.Guy Harris1-1/+1
"get_addr_name()" -> "ep_address_to_display()", to 1) indicate that it returns a string with ephemeral scope and 2) indicate that it maps an address to a "displayable" form - a name if possible, an address string if not. "se_get_addr_name()" -> "get_addr_name()", to indicate that its strings have the same scope as "get_ether_name()", "get_hostname()", and "get_hostname6()". Change-Id: If2ab776395c7a4a163fef031d92b7757b5d23838 Reviewed-on: https://code.wireshark.org/review/1216 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2014-03-04Remove all $Id$ from top of fileAlexis La Goutte1-2/+0
(Using sed : sed -i '/^ \* \$Id\$/,+1 d') Fix manually some typo (in export_object_dicom.c and crc16-plain.c) Change-Id: I4c1ae68d1c4afeace8cb195b53c715cf9e1227a8 Reviewed-on: https://code.wireshark.org/review/497 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2013-12-08From David Ameiss via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9509Alexis La Goutte1-1/+1
qtshark Flow Graph displays wrong information in comments column In qtshark, the flow graph is displaying the the frame label in the comments field. A simple fix, the patch is attached. svn path=/trunk/; revision=53849
2013-11-12Highlight selected sequence diagram items.Gerald Combs1-4/+62
svn path=/trunk/; revision=53294
2013-11-11Sequence / flow diagram updates.Gerald Combs1-0/+1
Plumb some controls. Adjust dialog layout. Make sure sequence information is allocated and freed correctly. Remove a debugging statement. svn path=/trunk/; revision=53260
2013-10-28More size and position tweaks.Gerald Combs1-14/+18
svn path=/trunk/; revision=52913
2013-10-27Try to improve the appearance of the sequence diagram.Gerald Combs1-12/+15
Use integer coordinates for the arrows and text. Add smooth_font_size() to qt_ui_utils which will hopefully adjust the size on Windows to something more readable. svn path=/trunk/; revision=52906
2013-10-25More sequence dialog updates.Gerald Combs1-8/+57
Draw item labels and port numbers. Update the hint text. Make items selectable. Resize fonts similar to the GTK+ version. Add scrollbars. Update the cursor. Use pango_layout_set_ellipsize() in the GTK+ code. Fixup comments. svn path=/trunk/; revision=52855
2013-10-25Add SVN properties.Jeff Morriss1-1/+1
svn path=/trunk/; revision=52832
2013-10-24Initial and woefully incomplete flow graph support.Gerald Combs1-0/+227
Copy common code from ui/gtk/flow_graph.c and ui/gtk/graph_analysis.[ch] to ui/tap-sequence-analysis.[ch]. Start using the name "sequence" in places. svn path=/trunk/; revision=52824
generated by cgit v1.2.1 (git 2.18.0) at 2024-05-27 01:55:31 +0000