summaryrefslogtreecommitdiff
path: root/ui/tap-sequence-analysis.h
AgeCommit message (Collapse)AuthorFilesLines
2016-12-15VoIP Calls/Flow Sequence: Fix of showing nodes from previous callJiri Novak1-0/+6
When VoIP Calls/Flow Sequence generates list of nodes to show (nodes above flow), it do not clear the list from last call. As consequence of it, when second call is between hosts than first call, you see nodes which are not involved in call. Change-Id: I80f9acb09e6aa71b3a32bb6eacaeb5b4bb13b332 Reviewed-on: https://code.wireshark.org/review/19267 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-10-02Qt: Only color sequence analysis items having color filterStig Bjørlykke1-0/+1
Packets without a color filter will end up with fg_color and bg_color = 0, so avoid drawing all in black. Bug: 12065 Change-Id: I76bcabcfa3281fcece08f1b2af66274c808b80bb Reviewed-on: https://code.wireshark.org/review/18018 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
2016-06-01Qt: Color _ANY and _TCP sequence analysis items.Gerald Combs1-1/+3
For SEQ_ANALYSIS_ANY, color each sequence diagram item according to its associated packet. For SEQ_ANALYSIS_TCP, color each item according to its stream. Bug: 12065 Change-Id: Ib43490fe55039fbcfa793223b5850233a2694a26 Reviewed-on: https://code.wireshark.org/review/15651 Reviewed-by: Gerald Combs <gerald@wireshark.org> Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2015-10-26Only store frame number and not a pointer to frame_data structure in ↵Pascal Quantin1-1/+1
seq_analysis_item_t Qt GUI allows to keep windows open after closing the capture file. Let's not access to freed memory. Bug: 11573 Change-Id: I9e70d818a4b228af319961ec512b6b9725792477 Reviewed-on: https://code.wireshark.org/review/11270 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Gerald Combs <gerald@wireshark.org>
2015-10-05Fix warnings introduced by "Qt: Initial RTP playback"Peter Wu1-6/+1
Change-Id: I28ae077be535f32ef81ac370d6782033f219017d Reviewed-on: https://code.wireshark.org/review/10777 Reviewed-by: Peter Wu <peter@lekensteyn.nl> Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com> Reviewed-by: Michael Mann <mmann78@netscape.net>
2015-10-02Qt: Initial RTP playback.Gerald Combs1-2/+17
Note the "initial". This is woefully incomplete. See the "to do" lists below and in the code. This differs a bit from the GTK+ version in that you specify one or more streams to be decoded. Instead of showing waveforms in individual widgets, add them all to a single QCustomPlot. This conserves screen real estate and lets us more easily take advantage of the QCP API. It also looks better IMHO. Change a bunch of checks for QtMultimediaWidgets to QtMultimedia. We probably won't use the widgets until we make 5.0 our minimum Qt version and plain old QtMultimedia lets us support Qt 4 more easily (in theory at least). Add resampling code from libspeex. I initially used this to resample each packet to match the preferred rate of our output device, but this resulted in poorer audio quality than expected. Leave it in and use to create visual samples for QCP and to match rates any time the rate changes. The latter is currently untested. Add some debugging macros. Note that both the RTP player and RTP analysis dialogs decode audio data using different code. Note that voip_calls_packet and voip_calls_init_tap appear to be dead code. To do: - Add silence frames where needed. - Implement the jitter buffer. - Implement the playback timing controls. - Tapping / scanning streams might be too slow. Change-Id: I20dd3b66d3df53c9b1f3501262dc01458849f6b4 Bug: 9007 Reviewed-on: https://code.wireshark.org/review/10458 Petri-Dish: Gerald Combs <gerald@wireshark.org> Reviewed-by: Gerald Combs <gerald@wireshark.org>
2015-08-19Preparation Host Flows: Tap Sequence AnalysisPascal Artho1-0/+1
The tap_sequence_analysis was adapted to store the protocol of each frame. Therefore a new variable was introduced. In case of an ICMP or ICMPv6 packet, the ICMP message type and code is retrieved. The adapted ICMP and ICMPv6 dissector stores both values in packet info (see [1]). In case of ICMP and ICMPv6 packets, the source and destination port is not set or 0, respectively. Compared to that, the NetFlow service export protocol [2] codes the ICMP message type and code into the port numbers. The source port is zero while the destination is defined as: destination port = ICMP type * 256 + ICMP code. This definition was implemented for the ICMP and ICMPv6 packets. References [1] https://code.wireshark.org/review/10097 [2] http://www.ietf.org/rfc/rfc3954.txt Change-Id: I07518e360975682a3f45e80cb24f82f58cfb15f0 Reviewed-on: https://code.wireshark.org/review/10098 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2014-12-09Qt: Initial VoIP Calls dialog.Gerald Combs1-2/+4
Add Telephony menu items for VoIP Calls and SIP Flows. Put VoIP Calls at the top, since that seems to be the primary item. Add configure-time checks for QtMultimediaWidgets in anticipation of adding a VoIP playback dialog. Add an icon for the playback button. (Yes, I've been avoiding GNOME-level gratuitous icons so far but this is one of the rare occiasions where it makes sense.) Add a help link define for the VoIP calls dialog. Change-Id: I5d0799685c598ad9af76fe9667f8ea7d14b66050 Reviewed-on: https://code.wireshark.org/review/5674 Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Gerald Combs <gerald@wireshark.org>
2014-11-26Consolidate sequence analysis code.Gerald Combs1-0/+10
Move scattered code for seq_analysis_info_t creation and destruction to tap-sequence-analysis.[ch]. Change-Id: I87c14b1c83105a48d0ab149a3abba71e2a2fe21f Reviewed-on: https://code.wireshark.org/review/5479 Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Gerald Combs <gerald@wireshark.org>
2014-11-18voip_calls: Regression fixes.Gerald Combs1-1/+1
Fix struct initialization logic. Clear a GQueue instead of deleting it. Don't crash if we have no sequence diagram items. Make sure we show all flows and not just invites. Zero allocated memory in a couple of places. Change-Id: Ia5bb3ba57cf625de4b554b354e098aa0361dff28 Reviewed-on: https://code.wireshark.org/review/5390 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2014-10-06Adjust some whitespace to match editor modelines.Bill Meier1-9/+9
Change-Id: I9fda7de49255857cc1cf270d6202c85573d91674 Reviewed-on: https://code.wireshark.org/review/4490 Reviewed-by: Bill Meier <wmeier@newsguy.com>
2014-06-27Use GQueue for generating statisticsBalint Reczey1-1/+1
This makes reversing the list back and forth to keep adding data at O(n) complexity obsolete. Bug: 9696 Change-Id: Ice77328b8f6c5bf72bbfcfd82e08d09d4f986d3f Reviewed-on: https://code.wireshark.org/review/2571 Reviewed-by: Balint Reczey <balint@balintreczey.hu> Tested-by: Balint Reczey <balint@balintreczey.hu>
2014-03-04Remove all $Id$ from top of fileAlexis La Goutte1-2/+0
(Using sed : sed -i '/^ \* \$Id\$/,+1 d') Fix manually some typo (in export_object_dicom.c and crc16-plain.c) Change-Id: I4c1ae68d1c4afeace8cb195b53c715cf9e1227a8 Reviewed-on: https://code.wireshark.org/review/497 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2014-02-25Remove trailing whitespaceBill Meier1-1/+1
Change-Id: I8116f63ff88687c8db3fd6e8e23b22ab2f759af0 Reviewed-on: https://code.wireshark.org/review/385 Reviewed-by: Bill Meier <wmeier@newsguy.com> Tested-by: Bill Meier <wmeier@newsguy.com>
2013-12-02Fix (-W)documentation error found by ClangAlexis La Goutte1-4/+4
parameter 'sai' not found in the function declaration [-Werror,-Wdocumentation] svn path=/trunk/; revision=53723
2013-11-12Sequence / flow diagram updates.Gerald Combs1-1/+1
Add "Save As..." Add a context menu and keyboard shortcuts. Add a tooltip. svn path=/trunk/; revision=53263
2013-10-25More sequence dialog updates.Gerald Combs1-1/+1
Draw item labels and port numbers. Update the hint text. Make items selectable. Resize fonts similar to the GTK+ version. Add scrollbars. Update the cursor. Use pango_layout_set_ellipsize() in the GTK+ code. Fixup comments. svn path=/trunk/; revision=52855
2013-10-24Initial and woefully incomplete flow graph support.Gerald Combs1-0/+129
Copy common code from ui/gtk/flow_graph.c and ui/gtk/graph_analysis.[ch] to ui/tap-sequence-analysis.[ch]. Start using the name "sequence" in places. svn path=/trunk/; revision=52824
generated by cgit v1.2.1 (git 2.18.0) at 2024-05-12 18:59:39 +0000