summaryrefslogtreecommitdiff
path: root/ui
AgeCommit message (Collapse)AuthorFilesLines
2015-09-21Make it possible to disable PercentBarDelegate.Gerald Combs2-1/+29
Add a check to PercentBarDelegate to see if the caller set text for this item or did not set a valid double value. If either case is true, just draw the item normally and return. Change-Id: I028ee15d54f06f2cb16c6e5f1ef73c47b2886ccd Reviewed-on: https://code.wireshark.org/review/10600 Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Gerald Combs <gerald@wireshark.org>
2015-09-21Qt: Add idle dissection.Gerald Combs3-1/+48
Features such as sorting and scroll bar colorization require fully-dissected packets. We currently do dissection at the wrong time -- *after* the user clicks on a packet list column header or moves the scrollbar. Add a timer + slot that dissects packets when the UI is idle so that our packets are at least partially dissected when we need them. Change-Id: I024c590af2250d67404a520f118e46ec0c49cd71 Reviewed-on: https://code.wireshark.org/review/10593 Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Gerald Combs <gerald@wireshark.org>
2015-09-20[Automatic update for 2015-09-20]Gerald Combs13-1084/+1109
Update manuf, services enterprise-numbers, translations, and other items. Change-Id: Ifcdb1c02406189085bda58bc7db10829e3fae2c0 Reviewed-on: https://code.wireshark.org/review/10580 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2015-09-19Start moving RTP decoding routines to the ui directory.Gerald Combs5-89/+234
Move decode_rtp_packet to ui/rtp_media.[ch]. Change-Id: Ib138781c37ac17b807bf75f9d772351aadf72071 Reviewed-on: https://code.wireshark.org/review/10575 Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Gerald Combs <gerald@wireshark.org>
2015-09-19Fix 'Decode As' when used with IPv6-in-IPv6 packetsPascal Quantin2-6/+40
Add the ability to identify an instance of the dissector table to be modified by 'Decode As' thanks to pinfo->curr_layer_num For now only IPv6 makes use of it but it could be extended to any other protocol Also get rid of ipv6.nxt protocol: it is not required for 'Decode As' functionality and was colliding with ipv6.nxt field Change-Id: I3c7403c77328ad7170e13af028d178f962a2b508 Reviewed-on: https://code.wireshark.org/review/10552 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: João Valverde <j@v6e.pt> Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2015-09-19Fix more signal+slot mismatches.Gerald Combs5-12/+12
Change-Id: I347509d3a7765387c48e5aaeaab417617320cf13 Reviewed-on: https://code.wireshark.org/review/10576 Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2015-09-19Fix a VoipCallsDialog signal+slot mismatch.Gerald Combs2-3/+3
Change-Id: I9c16cc138b55572aa19b6e02ca059ebde294bdbd Reviewed-on: https://code.wireshark.org/review/10574 Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Gerald Combs <gerald@wireshark.org>
2015-09-19Qt: set default current protocol in 'Decode As' window to none instead of HTTPPascal Quantin1-2/+2
It makes more sense (not trying to decode UDP/TCP ports as HTTP) and is consistent across dissectors tables (while currently we have an empty field for tables other than UDP/TCP) Change-Id: I794529f0f46b4197437a1d258f808991ae2338ad Reviewed-on: https://code.wireshark.org/review/10571 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com> Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2015-09-18Fix WLAN statistics header behavior.Gerald Combs1-1/+1
Connect itemSelectionChanged to header label updates instead of currentItemChanged, which seems to be more reliable. Change-Id: I29f8f2144ad6584e0612d43ec3aac5b258f08ebd Reviewed-on: https://code.wireshark.org/review/10570 Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Gerald Combs <gerald@wireshark.org>
2015-09-18Sync GTK+ and Qt progress timer logic.Gerald Combs1-4/+4
The GTK+ update_progress_dlg() initially forces a UI update. Do so in the Qt version as well. Change-Id: I05d9e61a0d0e4e05af448039bbb81785ac00908c Reviewed-on: https://code.wireshark.org/review/10568 Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Gerald Combs <gerald@wireshark.org>
2015-09-18Qt: flush visible rows before trying to select onePascal Quantin1-0/+1
Otherwise you end up with a 'End of capture exceeded' popup when calling rescan_packets() with only a few packets in the capture Change-Id: Idb387ce95f1d22b934e735c350ea0c117763d89a Reviewed-on: https://code.wireshark.org/review/10567 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Reviewed-by: Gerald Combs <gerald@wireshark.org>
2015-09-18main_toolbar (GTK): Fix no previous prototype for ↵Alexis La Goutte1-1/+2
‘plugin_if_maintoolbar_goto_frame’ [-Wmissing-prototypes] Change-Id: Ibb58694e730389b1e8ef3790595ed16d8699d37c Reviewed-on: https://code.wireshark.org/review/10563 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2015-09-18When we're updating the progress bar, ask that it be updated (redrawn) too.Jeff Morriss1-0/+3
At least on Linux/X11 with Qt5 this appears to be necessary so the progress bar updates more than once every 2 seconds or so (when loading a large file). Change-Id: I7eea9c0d97d24bc14ad75f082a3531dcf1a3b6ae Reviewed-on: https://code.wireshark.org/review/10559 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2015-09-17Fix some signal → slot mismatches.Gerald Combs4-9/+9
Update some signal definitions to match gb4e972b. Bug: 11524 Change-Id: I0d98a4e83c791221962943c3dec8f0d4296d3027 Reviewed-on: https://code.wireshark.org/review/10557 Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Gerald Combs <gerald@wireshark.org>
2015-09-17Qt: Add an event processing timer.Gerald Combs4-7/+16
When updating the progress dialog (which happens each time we read a packet) the GTK+ UI processes application events every 100ms. Do the same in the Qt UI. Ping-Bug: 11515 Change-Id: Ic53eade05c0b82bf436c08618f28506c5fcdbc94 Reviewed-on: https://code.wireshark.org/review/10554 Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Gerald Combs <gerald@wireshark.org>
2015-09-17Packet list speedups.Gerald Combs5-22/+68
beginInsertRows + endInsertRows is expensive. Instead of calling them each time we add a packet to the list, queue up a list of visible packets and flush it during the next UI update. Assume that none of our column data has newlines. Enable uniformRowHeights and only disable it when we need to. Note that this requires further work. Ping-Bug: 11515 Ping-Bug: 10924 Change-Id: Ifbdd2964b174247a4745d4889ebda5bf3b886ba4 Reviewed-on: https://code.wireshark.org/review/10553 Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Gerald Combs <gerald@wireshark.org>
2015-09-15MTP3 Summary: fix no previous prototype for ↵Alexis La Goutte1-1/+2
‘register_tap_listener_gtk_mtp3_summary’ [-Wmissing-prototypes] Change-Id: Iee26ba47802f3091f7e7264d2d7ce4b5e22db53c Reviewed-on: https://code.wireshark.org/review/10536 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2015-09-15Eliminate proto_tree_add_text from odds and ends.Michael Mann2-10/+8
A few calls in the epan directory and comments in the ui directory Change-Id: Ia8f8830ac6909ab94d3a03283bfd173456bc9718 Reviewed-on: https://code.wireshark.org/review/10492 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2015-09-14Qt: align display of packets statistics in status bar with GTK UIPascal Quantin1-5/+16
Bug: 11517 Change-Id: Ie47b7eebe58e8a9ac485ddd04fe074c94a0c6741 Reviewed-on: https://code.wireshark.org/review/10531 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com> Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Christopher Maynard <Christopher.Maynard@gtech.com>
2015-09-14Qt: add displayed packets percentage to status barPascal Quantin1-1/+2
Bug: 11517 Change-Id: Ic8195e4bc3874eb527ce9afa850ab8cba74ddcfe Reviewed-on: https://code.wireshark.org/review/10512 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com> Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2015-09-13Qt: remove unused variables in IAX2 analysis codePascal Quantin1-4/+0
Spotted by Coverity Change-Id: I4877eb282890415fbd24cbc6e48ababa46109b12 Reviewed-on: https://code.wireshark.org/review/10510 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2015-09-13Qt: refresh column content after editing itPascal Quantin2-1/+7
Also save the new value in preferences Change-Id: Ie1a942669ebc2824c999621ecd948425b3b49574 Reviewed-on: https://code.wireshark.org/review/10500 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com> Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Gerald Combs <gerald@wireshark.org>
2015-09-13Don't invalidate the column cache when we filter packets.Gerald Combs2-6/+3
Limit PacketListModel::recreateVisibleRows to checking for packets that passed the display filter. Remove the call to resetColumns, which invalidates the column string cache. Call PacketListModel::resetColumns from PacketList::columnsChanged. Along with invalidating the column string cache, this triggers a widget update which means we shouldn't need to call recreateVisibleRows or redrawVisiblePackets. Remove them. Change-Id: Ic25f139e2c2f8cdebb2a868ccda7eb4127a3013c Ping-Bug: 11324 Ping-Bug: 11514 Reviewed-on: https://code.wireshark.org/review/10491 Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com> Reviewed-by: Gerald Combs <gerald@wireshark.org>
2015-09-13Stock icon (Qt): Missing break in switch (CID 1323928)Alexis La Goutte1-0/+1
Add a "// Fall through" comment to squelch a Coverity warning. Hopefully the regex described at http://security.coverity.com/blog/2013/Sep/gimme-a-break.html is case-insensitive. Change-Id: I10be63a77ed1e5e0c8000bad0c1b8d08db8b0951 Reviewed-on: https://code.wireshark.org/review/10509 Reviewed-by: Gerald Combs <gerald@wireshark.org> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2015-09-13help_url: fix typo found by Coverity (CID 1323927) and Clang analyzerAlexis La Goutte1-2/+3
Change-Id: I26fda5d118d55f26f449ed858e9e57d477709bcb Reviewed-on: https://code.wireshark.org/review/10508 Reviewed-by: Michael Mann <mmann78@netscape.net>
2015-09-13[Automatic update for 2015-09-13]Gerald Combs13-4189/+6797
Update manuf, services enterprise-numbers, translations, and other items. Change-Id: I0c7a8d1ad41d5509c35f110aa50b7b86aa5a73c4 Reviewed-on: https://code.wireshark.org/review/10514 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2015-09-13Fix misaligned read and buffer overrunPeter Wu2-21/+13
Ethernet addresses are only 6 bytes in size, reading it as a 64-bit integer is invalid. Use unsigned 8-bit integers instead. Caught by UBSAN and Address Sanitizer. Trigger via the Statistics menu Resolved Addresses (Qt) or Show address resolution (GTK). Change-Id: I628ff7cce0ea4f4e378c7968cd79a0ae34cdd20b Reviewed-on: https://code.wireshark.org/review/10443 Reviewed-by: ronnie sahlberg <ronniesahlberg@gmail.com> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Evan Huus <eapache@gmail.com>
2015-09-11Fix a bunch of leaks found by Valgrind.Gerald Combs14-39/+48
Change-Id: I8862ed15d354aee487bacd80ab5fb4918423287e Reviewed-on: https://code.wireshark.org/review/10487 Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Gerald Combs <gerald@wireshark.org>
2015-09-11Try using GStringChunks in PacketListRecord.Gerald Combs3-10/+32
This saves a fair amount of memory in tests here. Loading a large capture file and sorting on a custom column (tcp.window_size) uses 676 MB before the change and 634 after. Add notes about possble further improvements: Roll our own replacement for GStringChunks using wmem_tree. Have PacketListRecord::columnString return a const char * instead of a const QByteArray. Change-Id: Icb36194f5ad290828d7106ccc3bf494d07d76d08 Reviewed-on: https://code.wireshark.org/review/10476 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2015-09-11Make sure we delete our PacketListRecords.Gerald Combs1-0/+1
This fixes a serious (and obvious) memory leak in the packet list. Change-Id: Ie3d21e1a1d09a3481c9649954c25b9ae73b8e32a Reviewed-on: https://code.wireshark.org/review/10485 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2015-09-11Export captured packets correctly.Gerald Combs3-2/+22
Make sure we set and unset the "process_filtered" field of our range in PacketRangeGroupBox. Otherwise we only export displayed packets. Make sure we set "remove_ignored" as well. Ignore the cf_cb_file_export_specified_packets_* callbacks in CaptureFile so that we don't print spurious warnings. Bug: 11473 Bug: 11428 Change-Id: Ica551addd3af2de79f7cd47a2cc361043d2982e5 Reviewed-on: https://code.wireshark.org/review/10477 Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Gerald Combs <gerald@wireshark.org>
2015-09-11Make StockIconToolButton independent.Gerald Combs11-188/+250
A recent set of changes replaced the "dfilter_erase_" images with an "x-filter-clear" stock icon set. Move StockIconToolButton to its own compilation unit. Use it in CaptureFilterEdit and ProgressFrame to load the "x-filter-clear" icon. Bug: 11516 Change-Id: I5d5864d089fb56827d130d493d53e7de6a7c03b5 Reviewed-on: https://code.wireshark.org/review/10475 Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Gerald Combs <gerald@wireshark.org>
2015-09-11qt: Fix crash when stopping an empty live capturePeter Wu1-5/+7
When the capture process has not yet received any packets (not even the libpcap header), Wireshark-Qt would crash because no valid capture file was found. Reproducer: ssh otherhost sleep 10000 | wireshark -k -i - GTK displays "Waiting for capture input data" in the status bar until the capture file format is determined. After this patch, both versions will just display an "Interrupted system call" message. Change-Id: I146f00c0f4fcab04cddcd4f29b56e97b807a9c40 Reviewed-on: https://code.wireshark.org/review/10388 Reviewed-by: Peter Wu <peter@lekensteyn.nl> Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: ronnie sahlberg <ronniesahlberg@gmail.com>
2015-09-11lte/ui: fix 'time' var name.Dario Lombardo4-20/+20
As pointed out by checkAPI.pl. Change-Id: Ibab9b2720f3ef666b06b2b61ffc54aa23cbb01fc Reviewed-on: https://code.wireshark.org/review/10469 Reviewed-by: Michael Mann <mmann78@netscape.net> Petri-Dish: Michael Mann <mmann78@netscape.net> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2015-09-10Check if -fPIC is needed for Qt5 code to compileJeffrey Smith1-1/+1
On many systems, Qt5 requires that code compiled against it must compile with -fPIC. The preferred place to determine whether this is necessary is at configure time. This change adds the auto-tool code to make that happen and removes the hack put in place as an interim solution. Bug: 11230 Change-Id: I6e583c67bb67d168a30c0af05a8cd0a070522ba0 Reviewed-on: https://code.wireshark.org/review/10281 Petri-Dish: Jeff Morriss <jeff.morriss.ws@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Jeff Morriss <jeff.morriss.ws@gmail.com>
2015-09-09Add the IAX2 Analysis dialog.Gerald Combs16-37/+2008
Copied from the RTP Analysis dialog, just like the GTK+ version. Change-Id: I111020bc4073a3a3ba583bdace51a91ee5fef300 Reviewed-on: https://code.wireshark.org/review/10447 Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Gerald Combs <gerald@wireshark.org>
2015-09-09Add the Telephony→LTE menu.Gerald Combs2-0/+24
Add an empty (for now) Telephony→LTE menu ahead of upcoming changes. Change-Id: Ic6686b653d2fa51f1eb6854ab0952f92d679bccc Reviewed-on: https://code.wireshark.org/review/10452 Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Gerald Combs <gerald@wireshark.org>
2015-09-09Fix Flow Graph never using Standard Addresses when requestedBen Fox-Moore1-1/+1
Bug: 10966 Change-Id: I5ccc78b8c39f623a4e157572d1caa228c9bb3713 Reviewed-on: https://code.wireshark.org/review/10450 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2015-09-09codecs/gtk: fix int to size_tDario Lombardo1-14/+18
Change-Id: I8f467f09375c8227c4b70aef47ff3a590a0c00d7 Reviewed-on: https://code.wireshark.org/review/10413 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Guy Harris <guy@alum.mit.edu>
2015-09-09PluginIF: Fix GTK PluginIF interfaceRoland Knall3-29/+39
- Move the apply-filter code to main_menubar, because there already the code of the preference pop-ups is handled - Fix the apply-filter callback, which was not working at all Change-Id: I25d5a161d8b78695c15b3100653be36786129408 Reviewed-on: https://code.wireshark.org/review/10444 Reviewed-by: Roland Knall <rknall@gmail.com> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2015-09-08PluginIF: Parent menu and goto frameRoland Knall4-5/+73
The developer may provide a given menu as parent menu for the sub menu. If the menu does not exist, the main menu will be used. Has been implemented for Qt as well as GTK. Change-Id: I3f26684862fd0b08f59eeb4d6f4a24ce7dc3d428 Reviewed-on: https://code.wireshark.org/review/9939 Reviewed-by: Roland Knall <rknall@gmail.com> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
2015-09-08Qt: Fixed a resource leak in getFilterFromRowAndColumnStig Bjørlykke2-3/+3
Found by coverity CID 1314608 and Apple Instruments. Change-Id: I264ce335bd8985946a097bb8f99f7c41c0eb027d Reviewed-on: https://code.wireshark.org/review/10378 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
2015-09-08Qt: Fixed a resource leak in updateSelectionStatusStig Bjørlykke1-2/+3
Avoid passing a reference to a allocated QString, which will never be deleted. This fixes a 16 Bytes leak each time an element is selected or deselected in the packet tree. Change-Id: If0d7482bf505fda8802dd58e8d1841b7da6b6294 Reviewed-on: https://code.wireshark.org/review/10393 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
2015-09-08Qt: Fix use-after-free patternStig Bjørlykke4-12/+23
This fixes crashes due to use of deallocated memory in: - Export Packet Dissections - Merge Capture Files - Edit Packet Comment Change-Id: I3dab8c0735eb5e642d6a4580d20bc3c81cf1345b Reviewed-on: https://code.wireshark.org/review/10392 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
2015-09-07Enable the display filter arrow tooltip.Gerald Combs2-3/+29
Add an event handler which ensures that the tooltip displays only when we're over the arrow subcontrol. Change-Id: I14d308344d9dd4d4ffbc7b0fe568c95f21f9a641 Reviewed-on: https://code.wireshark.org/review/10417 Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Gerald Combs <gerald@wireshark.org>
2015-09-07Add a URL for the tooltip bug.Gerald Combs1-3/+5
It should be fixed in Qt 5.5.1. Change-Id: I32fa11accdd6bea953341dd6b4914686cacda98e Reviewed-on: https://code.wireshark.org/review/10419 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2015-09-07Re-enable display filter editor tooltips.Gerald Combs2-7/+30
Enforce correct "leave" behavior using a timer. Change-Id: I59b8fd08c27fd463363bdda090fb9c24f664d9eb Reviewed-on: https://code.wireshark.org/review/10408 Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Gerald Combs <gerald@wireshark.org>
2015-09-06Disable display filter tooltips for now.Gerald Combs2-27/+27
Comment out the setToolTip call in DisplayFilterCombo. The function applies to the entire control, but the text only makes sense for the drop-down arrow. Remove the tooltip for the clear button in DisplayFilterEdit. If the purpose of the "X" symbol isn't obvious then we aren't doing our job properly. Comment out the other setToolTip calls in DisplayFilterEdit for now since they interfere with leaveEvents. Add a note about a possible workaround. Change-Id: I055a30b6a5b5e07cebf1fa36e217654d390d34d0 Reviewed-on: https://code.wireshark.org/review/10405 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2015-09-06Keep focus rects from showing through the welcome screen.Gerald Combs3-0/+13
Change-Id: I5785890c70f3a3f6f4ccb0c7b609a19e5d2b88c9 Reviewed-on: https://code.wireshark.org/review/10406 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2015-09-06[Automatic update for 2015-09-06]Gerald Combs13-4153/+5341
Update manuf, services enterprise-numbers, translations, and other items. Change-Id: If1cc31f1cd036c536a8a8bb9d9094bdb7c9f6f07 Reviewed-on: https://code.wireshark.org/review/10403 Reviewed-by: Gerald Combs <gerald@wireshark.org>
generated by cgit v1.2.1 (git 2.18.0) at 2024-06-16 14:07:05 +0000