diff options
| author | Bastien Nocera <hadess@hadess.net> | 2013-10-17 12:40:41 +0200 |
|---|---|---|
| committer | Bastien Nocera <hadess@hadess.net> | 2013-10-17 14:25:25 +0200 |
| commit | 0010e9325110e5a70a0d2381c84f88e7fb044ce4 (patch) | |
| tree | ffd6d04397da8d8dea883b43a95e21e5d5a4ad2b /src/up-device.c | |
| parent | 8453da5014e6750ff2cdffcaa3a89dd616ca7434 (diff) | |
| download | upower-0010e9325110e5a70a0d2381c84f88e7fb044ce4.tar.gz | |
all: Remove *changed signals
Now that we send out PropertiesChanged signals (on the daemon side)
and "notify" signals (on the client side), there's no need for the
all encompassing DeviceChanged and Changed signals.
They would have woken up any client, even if they were not interested
in receiving the signals.
Diffstat (limited to 'src/up-device.c')
| -rw-r--r-- | src/up-device.c | 20 |
1 files changed, 0 insertions, 20 deletions
diff --git a/src/up-device.c b/src/up-device.c index 746e9b8..be141f8 100644 --- a/src/up-device.c +++ b/src/up-device.c @@ -119,13 +119,6 @@ enum { PROP_LAST }; -enum { - SIGNAL_CHANGED, - SIGNAL_LAST, -}; - -static guint signals[SIGNAL_LAST] = { 0 }; - G_DEFINE_TYPE (UpDevice, up_device, G_TYPE_OBJECT) #define UP_DEVICE_GET_PRIVATE(o) (G_TYPE_INSTANCE_GET_PRIVATE ((o), UP_TYPE_DEVICE, UpDevicePrivate)) #define UP_DBUS_STRUCT_UINT_DOUBLE_UINT (dbus_g_type_get_struct ("GValueArray", \ @@ -1005,11 +998,6 @@ up_device_perhaps_changed_cb (GObject *object, GParamSpec *pspec, UpDevice *devi up_history_set_rate_data (device->priv->history, device->priv->energy_rate); up_history_set_time_full_data (device->priv->history, device->priv->time_to_full); up_history_set_time_empty_data (device->priv->history, device->priv->time_to_empty); - - /* The order here matters; we want Device::Changed() before - * the DeviceChanged() signal on the main object */ - g_debug ("emitting changed on %s", device->priv->native_path); - g_signal_emit (device, signals[SIGNAL_CHANGED], 0); } /** @@ -1071,14 +1059,6 @@ up_device_class_init (UpDeviceClass *klass) g_type_class_add_private (klass, sizeof (UpDevicePrivate)); - signals[SIGNAL_CHANGED] = - g_signal_new ("changed", - G_OBJECT_CLASS_TYPE (klass), - G_SIGNAL_RUN_LAST | G_SIGNAL_DETAILED, - 0, NULL, NULL, - g_cclosure_marshal_VOID__VOID, - G_TYPE_NONE, 0); - dbus_g_object_type_install_info (UP_TYPE_DEVICE, &dbus_glib_up_device_object_info); /** |