summaryrefslogtreecommitdiff
path: root/src/linux
AgeCommit message (Collapse)AuthorFilesLines
2014-11-26daemon: release resources at shutdownPeter Wu1-0/+27
This makes it easier to find real memory leaks with valgrind. After calling the up_backend_unplug functions, you cannot restart it with up_backend_coldplug since the lists are cleared. Tested with Linux only (not on *BSD; dummy compiles). https://bugs.freedesktop.org/show_bug.cgi?id=82659
2014-11-26daemon: fix various reference leaksPeter Wu1-1/+4
up_daemon_get_daemon takes a reference on UpDaemon, so it must be properly dereferenced. Similar for up_daemon_get_devices_list which references an UpDeviceList. The display device was allocated in init, but never released either. https://bugs.freedesktop.org/show_bug.cgi?id=82659
2014-11-26hidpp: fix memleak for each FeaturePeter Wu1-1/+12
The name of each Logitech HID++ 2.0 Feature will now be freed. https://bugs.freedesktop.org/show_bug.cgi?id=82659
2014-11-26linux: fix memleak when reading critical actionPeter Wu1-1/+1
g_variant_get for string types must be freed as documented at https://developer.gnome.org/glib/stable/gvariant-format-strings.html#gvariant-format-strings-strings Since we just want to compare it, use a pointer as documented at https://developer.gnome.org/glib/stable/gvariant-format-strings.html#gvariant-format-strings-pointers https://bugs.freedesktop.org/show_bug.cgi?id=82659
2014-11-18hidpp-device: avoid unaligned memory accessPeter Wu1-3/+3
Fixes a -Wcast-align warning and a -fsanitize=undefined error. https://bugs.freedesktop.org/show_bug.cgi?id=71079
2014-10-08upowerd: Fix cleanup in up_device_idevice_coldplug/finalizeNikolay Martynov1-3/+8
Under certain conditions lockdownd_client_free was called twice for same client. This caused SIGSEGV. This patch addresses this issue Signed-off-by: Nikolay Martynov <mar.kolya@gmail.com> Signed-off-by: Richard Hughes <richard@hughsie.com>
2014-10-08all: convert value from g_get_real_time() to secondsEvangelos Foutras6-6/+6
Commit 5ddfe0d (all: Use g_get_real_time() when possible) replaced calls to g_get_current_time() with g_get_real_time(), however, we also need to convert the return value from microseconds to seconds. Signed-off-by: Richard Hughes <richard@hughsie.com>
2014-09-24all: Use g_get_real_time() when possibleBastien Nocera6-20/+7
Instead of a call to g_get_current_time().
2014-09-16Correct check to prevent the display of invalid ASCII codesEric Koegel1-1/+1
Cppcheck found it as a logical conjunction always evaluates to false: EXPR < 32 && EXPR > 126. Change the expression to an Or. https://bugs.freedesktop.org/show_bug.cgi?id=71066 Signed-off-by: Richard Hughes <richard@hughsie.com>
2014-09-02linux: Respect the CriticalPowerAction config optionBastien Nocera1-2/+14
It was documented, but the configuration was never actually read. https://bugs.freedesktop.org/show_bug.cgi?id=82925
2014-09-02Linux integration tests: Split big tests into several smaller onesMartin Pitt1-19/+51
This is better design to catching regressions and problems in a more pin-pointed fashion. This also avoids having to restart the umockdev testbed due to changing the environment variables with stop/start_daemon().
2014-09-02Linux integration tests: Fix error handling for Python 3.4Martin Pitt1-1/+2
Python 3.4 changed the TestCase._outcome semantics, adjust accordingly.
2014-09-02Linux integration tests: Fix crash if there is no session D-BUSMartin Pitt1-1/+4
This can happen in CI environments without a desktop session.
2014-06-24linux: Simplify list freeingBastien Nocera2-4/+2
2014-06-24linux: Fix small memleak on startup with Logitech devicesBastien Nocera1-2/+2
2014-05-07linux: Remove is_docked from the integration testBastien Nocera1-1/+0
2014-05-07daemon: Deprecate "IsDocked" propertyBastien Nocera4-274/+0
The IsDocked property has been incorrect for a number of laptops for a while, as it thought that laptops with hybrid graphics cards were always docked. The alternative would have been to use the platform/dock_station devices, but those are only exported for ACPI docking stations. Instead, whether an external display is attached (which isn't really docking) should be checked in the same place where the policy depending on the value should be applied, such as gnome-settings-daemon. https://bugs.freedesktop.org/show_bug.cgi?id=36818
2013-10-29trivial: Fix a compile warning in the linux backendRichard Hughes1-1/+1
2013-10-28linux: Use daemon poll for batteries tooBastien Nocera1-73/+23
This has 2 effects: - we never stop polling (we used to stop polling when the battery was marked as fully-charged, but that can happen when the battery is discharging too) - when in an unknown state, we will poll through the daemon, and through our unknown poll. This isn't a problem as there'll another 115 seconds of wait until we get to poll through the daemon again.
2013-10-28linux: Switch non-battery devices to use the new daemon pollBastien Nocera1-2/+22
Next up is doing this for batteries, which need to switch between a normal/slow poll to a faster one when the battery state is unknown.
2013-10-28linux: Switch Unifying devices to use the new daemon pollBastien Nocera1-9/+2
2013-10-28linux: Switch iDevices to use the new daemon pollBastien Nocera1-22/+2
And remove the gathering of the battery poll from the device itself, it's of nearly no use.
2013-10-28linux: Switch CSR devices to use the new daemon pollBastien Nocera1-7/+2
2013-10-26daemon: Better timeout source namingBastien Nocera7-10/+30
Matching the work done in glib, gtk+, etc. This also differentiates the unknown and normal timeouts in the Linux power supply driver.
2013-10-26linux: Add NoPollBatteries configuration optionBastien Nocera1-3/+13
For system integrators. If your firmware is helpful to user space and automatically sends out uevent when the battery level changes (rather than just the battery state) as on most machines, you can enable "NoPollBatteries" in the configuration option, and reduce power consumption from UPower and its listeners.
2013-10-26linux: Split up battery and device refreshBastien Nocera1-7/+7
In up_device_supply_refresh().
2013-10-26linux: Move poll disable to another functionBastien Nocera1-4/+12
2013-10-26linux: Only disable timeouts if ever setBastien Nocera1-5/+5
We cannot ever set the refresh timeout when we have a power line device, so don't try and remove it there.
2013-10-26linux: Poll for unknown state like the daemon didBastien Nocera1-2/+2
5 times, with 1 second timeouts, instead of 30 times, with 2 seconds timeouts.
2013-10-26linux: Fix the "unknown state" heavy pollBastien Nocera1-9/+15
It was never actually setup, as the fallback state was used to check whether we should use poll or not.
2013-10-22linux: Clamp percentage for overfull batteriesMartin Pitt2-0/+37
Some batteries report energy > energy_full and a percentage ("capacity" attribute) > 100%. Clamp these within 0 and 100% for both plausibility as well as to avoid setting an out-of-range property which would then become 0%. https://launchpad.net/bugs/1240673
2013-10-20linux: Fix parsing of double values for certain localesBastien Nocera1-2/+2
I don't think the kernel exports any numbers with a decimal portion, but if they did, they would get the wrong values because some locales use "," as the decimal separator, and not "." as the kernel/C locale would.
2013-10-18linux: Finish "fixing" the UPS test caseBastien Nocera1-4/+10
Update the expected warning levels to match, and add a big fat FIXME for the test case itself. That's not how UPSes work, or how UPower is expected to work.
2013-10-18daemon: Fix typos in commentsBastien Nocera1-1/+1
2013-10-18linux: More information in the debug outputBastien Nocera1-1/+1
As was the case in other places, we need to be able to differentiate warning messages for them to be useful.
2013-10-18linux: Fix tests for "OnLowBattery"Bastien Nocera1-23/+23
Replace them all with WarningLevel tests. Note we current crash when adding a UPS, in test_ups_ac.
2013-10-18linux: Add TODO item for the GetCriticalAction bindingBastien Nocera1-0/+2
2013-10-18linux: get_properties_sync() doesn't exist anymoreBastien Nocera1-1/+0
2013-10-18linux: Add helper to get DisplayDevice propertyBastien Nocera1-0/+8
In the integration tests.
2013-10-18linux: Add new definitionsBastien Nocera1-0/+8
Proxy paths, and enumeration from the current API.
2013-10-18linux: Mark devices with 100% battery as fullBastien Nocera1-0/+5
2013-10-18linux: Fix Bluetooth devices appearing with 0% batteryBastien Nocera1-1/+7
When switching off Bluetooth devices, and before they timeout, we won't be able to read the battery percentage, so don't overwrite the previous value with "0%", but set the state to unknown instead. https://bugs.freedesktop.org/show_bug.cgi?id=70325
2013-10-18linux: Add a way to check when sysfs_get_double failsBastien Nocera2-0/+20
2013-10-18linux: Use up_device_supply_get_string()Bastien Nocera1-5/+6
In up_device_supply_get_state()
2013-10-18linux: Add a simpler, quicker path for devicesBastien Nocera1-1/+66
When refreshing the state of device batteries, no need to get data that won't be there anyway, such as voltage, temperature, or consumption rate. This avoids warnings about voltage being unknown for devices, and cuts down on the properties churn.
2013-10-18linux: Split off device state retrievalBastien Nocera1-20/+31
We're going to be reusing this elsewhere.
2013-10-18linux: Ignore ACs coming from devicesBastien Nocera1-0/+7
We already have enough information on the device battery. This avoids having a device for the wacom AC which we won't use.
2013-10-18linux: Remove incorrect statementBastien Nocera1-1/+0
Not all "UpDeviceSupply" actually supply power to the computer.
2013-10-17linux: Use boolean values in sysfs_get_bool, not intBastien Nocera1-4/+3
2013-10-17linux: Remove unused sysfs utils functionsBastien Nocera2-110/+0